Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/Utils.h

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Rebased Created April 12, 2017, 8:49 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/AppInfoJsObject.cpp ('K') | « src/Thread.cpp ('k') | src/Utils.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/Utils.h
===================================================================
--- a/src/Utils.h
+++ b/src/Utils.h
@@ -24,23 +24,23 @@
#include <istream>
#include <string>
#include <v8.h>
namespace AdblockPlus
{
namespace Utils
{
- std::string Slurp(std::istream& stream);
- std::string FromV8String(v8::Handle<v8::Value> value);
+ std::string Slurp(const std::istream& stream);
sergei 2017/04/12 13:34:31 The same https://codereview.adblockplus.org/294095
hub 2017/04/12 13:51:35 It calls istream::rdbuf() which takes a const obje
+ std::string FromV8String(const v8::Handle<v8::Value>& value);
v8::Local<v8::String> ToV8String(v8::Isolate* isolate, const std::string& str);
// Code for templated function has to be in a header file, can't be in .cpp
template<class T>
- T TrimString(T text)
+ T TrimString(const T& text)
{
// Via http://stackoverflow.com/questions/216823/whats-the-best-way-to-trim-stdstring
T trimmed(text);
trimmed.erase(trimmed.begin(), std::find_if(trimmed.begin(), trimmed.end(), std::not1(std::ptr_fun<int, int>(std::isspace))));
trimmed.erase(std::find_if(trimmed.rbegin(), trimmed.rend(), std::not1(std::ptr_fun<int, int>(std::isspace))).base(), trimmed.end());
return trimmed;
}
#ifdef _WIN32
« src/AppInfoJsObject.cpp ('K') | « src/Thread.cpp ('k') | src/Utils.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld