Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/JsValue.h

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: the input stream is no longer const. Created April 12, 2017, 3:08 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/AdblockPlus/JsEngine.h ('k') | src/AppInfoJsObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/JsValue.h
===================================================================
--- a/include/AdblockPlus/JsValue.h
+++ b/include/AdblockPlus/JsValue.h
@@ -120,17 +120,17 @@
/**
* Invokes the value as a function (see `IsFunction()`).
* @param params Optional list of parameters.
* @param thisPtr Optional `this` value.
* @return Value returned by the function.
*/
JsValue Call(const JsConstValueList& params = JsConstValueList(),
- AdblockPlus::JsValuePtr thisPtr = AdblockPlus::JsValuePtr()) const;
+ const AdblockPlus::JsValuePtr& thisPtr = AdblockPlus::JsValuePtr()) const;
/**
* Invokes the value as a function (see `IsFunction()`) with single
* parameter.
* @param arg A single required parameter.
* @return Value returned by the function.
*/
JsValue Call(const JsValue& arg) const;
« no previous file with comments | « include/AdblockPlus/JsEngine.h ('k') | src/AppInfoJsObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld