Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/FilterEngine.cpp

Issue 29409580: Issue 5013 - Make parameter const ref when applicable. (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: the input stream is no longer const. Created April 12, 2017, 3:08 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/FileSystemJsObject.cpp ('k') | test/Prefs.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/FilterEngine.cpp
===================================================================
--- a/test/FilterEngine.cpp
+++ b/test/FilterEngine.cpp
@@ -61,17 +61,17 @@
typedef FilterEngineTestGeneric<LazyFileSystem, AdblockPlus::DefaultLogSystem> FilterEngineTest;
typedef FilterEngineTestGeneric<VeryLazyFileSystem, LazyLogSystem> FilterEngineTestNoData;
struct MockFilterChangeCallback
{
MockFilterChangeCallback(int& timesCalled) : timesCalled(timesCalled) {}
- void operator()(const std::string&, const AdblockPlus::JsValuePtr)
+ void operator()(const std::string&, const AdblockPlus::JsValue&)
{
timesCalled++;
}
private:
int& timesCalled;
};
@@ -1087,9 +1087,9 @@
auto subscription = EnsureExampleSubscriptionAndForceUpdate("subB");
EXPECT_EQ("synchronize_ok", subscription->GetProperty("downloadStatus")->AsString());
EXPECT_EQ(1u, subscription->GetProperty("filters")->AsList().size());
auto capturedConnectionTypes = this->capturedConnectionTypes.GetStrings();
ASSERT_EQ(1u, capturedConnectionTypes.size());
EXPECT_TRUE(capturedConnectionTypes[0].first);
EXPECT_EQ(testConnection, capturedConnectionTypes[0].second);
}
-}
+}
« no previous file with comments | « test/FileSystemJsObject.cpp ('k') | test/Prefs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld