Issue 5131 - [emscripten] Clean separation of bindings code and runtime code

compiled/bindings/generator.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 24 matching lines @@
 {
   typedef void* TYPEID;
 
   enum class TypeCategory
   {
     UNKNOWN,
     VOID,
     INT,
     INT64,
     FLOAT,
+    DOUBLE,
     DEPENDENT_STRING,
     OWNED_STRING,
     STRING_REF,
     CLASS_PTR
   };
 
   template<typename T>
   struct TypeInfo
   {
     /*
@@ skipping 14 matching lines @@
     {
       if (std::is_void<T>())
         return TypeCategory::VOID;
 
       if (std::is_same<T, uint64_t>())
         return TypeCategory::INT64;
 
       if (std::is_integral<T>() || std::is_enum<T>())
         return TypeCategory::INT;
 
-      if (std::is_floating_point<T>())
+      if (std::is_same<T, float>())
         return TypeCategory::FLOAT;
+
+      if (std::is_same<T, double>())
+        return TypeCategory::DOUBLE;
 
       if (std::is_same<DependentString, T>() || std::is_same<const DependentString, T>())
         return TypeCategory::DEPENDENT_STRING;
 
       if (std::is_same<OwnedString, T>() || std::is_same<const OwnedString, T>())
         return TypeCategory::OWNED_STRING;
 
       if (std::is_same<String&, T>() || std::is_same<const String&, T>() ||
         std::is_same<DependentString&, T>())
       {
@@ skipping 90 matching lines @@
   struct ClassInfo
   {
     TYPEID id;
     TYPEID baseClass;
     std::string name;
     std::vector<PropertyInfo> properties;
     std::vector<MethodInfo> methods;
     DifferentiatorInfo subclass_differentiator;
     ptrdiff_t ref_counted_offset;
   };
-
-  typedef std::function<void()>  CustomGenerator;
 
   void register_class(const char* name, TYPEID classID, TYPEID baseClassID,
                       ptrdiff_t ref_counted_offset);
 
   void register_property(TYPEID classID, const char* name,
       const FunctionInfo& getter, const FunctionInfo& setter,
       const char* jsValue = "");
 
   void register_method(TYPEID classID, const char* name,
       const FunctionInfo& call);
@@ skipping 12 matching lines @@
 
   void printClass(const ClassInfo& cls);
 }
 
 template<typename ClassType,
     typename BaseClass = bindings_internal::NoBaseClass,
     typename std::enable_if<std::is_base_of<ref_counted, ClassType>::value>::type* = nullptr>
 class class_
 {
 public:
   class_(const char* name)

[Wladimir Palant, 2017/04/12 14:17:00]

I would have preferred to move the implementations here into generator.cpp as
well but that appears to be still impossible with the current version of C++
standard.

   {
     ClassType* ptr = reinterpret_cast<ClassType*>(0x10000000);
     ptrdiff_t ref_counted_offset =
         reinterpret_cast<char*>(static_cast<ref_counted*>(ptr)) -
         reinterpret_cast<char*>(ptr);
     bindings_internal::register_class(name,
         bindings_internal::TypeInfo<ClassType>(),
         bindings_internal::TypeInfo<BaseClass>(),
         ref_counted_offset
       );
@@ skipping 54 matching lines @@
     std::vector<std::pair<int, std::string>> mapping;
     for (const auto& item : list)
       mapping.emplace_back(item.first, item.second);
 
     bindings_internal::register_differentiator(
         bindings_internal::TypeInfo<ClassType>(), offset, mapping);
     return *this;
   }
 };
 
-void custom_generator(bindings_internal::CustomGenerator generator);
-
 void printBindings();