Unified Diff: src/GlobalJsObject.cpp
Issue 29410664:
Issue 5013 - Use const JsValue and pass reference where applicable (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Remove the SetProperty() changes.
Created April 13, 2017, 1:16 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« include/AdblockPlus/JsValue.h ('K')
|
« src/FilterEngine.cpp ('k')
|
src/JsEngine.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: src/GlobalJsObject.cpp |
| =================================================================== |
| --- a/src/GlobalJsObject.cpp |
| +++ b/src/GlobalJsObject.cpp |
| @@ -49,17 +49,17 @@ |
| // used via clearTimeout(). But since we don't seem to need |
| // clearTimeout(), we can save that for later. |
| return v8::Undefined(); |
| } |
| v8::Handle<v8::Value> TriggerEventCallback(const v8::Arguments& arguments) |
| { |
| AdblockPlus::JsEnginePtr jsEngine = AdblockPlus::JsEngine::FromArguments(arguments); |
| - AdblockPlus::JsValueList converted = jsEngine->ConvertArguments(arguments); |
| + AdblockPlus::JsConstValueList converted = jsEngine->ConvertArguments(arguments); |
| if (converted.size() < 1) |
| { |
| v8::Isolate* isolate = arguments.GetIsolate(); |
| return v8::ThrowException(Utils::ToV8String(isolate, |
| "_triggerEvent expects at least one parameter")); |
| } |
| std::string eventName = converted.front()->AsString(); |
| converted.erase(converted.begin()); |
« include/AdblockPlus/JsValue.h ('K')
|
« src/FilterEngine.cpp ('k')
|
src/JsEngine.cpp » ('j')
|
no next file with comments »
