test/FilterEngine.cpp - Issue 29410664: Issue 5013 - Use const JsValue and pass reference where applicable

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: test/FilterEngine.cpp

Issue 29410664: Issue 5013 - Use const JsValue and pass reference where applicable (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Patch Set: Remove the SetProperty() changes. Created April 13, 2017, 1:16 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: test/FilterEngine.cpp

===================================================================

--- a/test/FilterEngine.cpp

+++ b/test/FilterEngine.cpp

@@ -229,17 +229,17 @@

exampleSubscriptionResponse.responseText = "[Adblock Plus 2.0]\n||example.com";

webRequest->responses.emplace(subscriptionUrlPrefix, exampleSubscriptionResponse);

createParams.preconfiguredPrefs["first_run_subscription_auto_select"] = jsEngine->NewValue(false);

isConnectionAllowed = true;

createParams.isConnectionAllowedCallback = [this](const std::string* allowedConnectionType)->bool{

capturedConnectionTypes.Add(allowedConnectionType);

return isConnectionAllowed;

};

- jsEngine->SetEventCallback("filterChange", [this](const JsValueList& params/*action, item*/)

+ jsEngine->SetEventCallback("filterChange", [this](const JsConstValueList& params/*action, item*/)

{

ASSERT_EQ(2u, params.size());

if (params[0]->AsString() == "subscription.downloadStatus")

{

std::lock_guard<std::mutex> lock(downloadStatusChanged.mutex);

downloadStatusChanged.url = params[1]->GetProperty("url")->AsString();

}