Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/UpdateCheck.cpp

Issue 29410664: Issue 5013 - Use const JsValue and pass reference where applicable (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Remove the SetProperty() changes. Created April 13, 2017, 1:16 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« include/AdblockPlus/JsValue.h ('K') | « test/JsEngine.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/UpdateCheck.cpp
===================================================================
--- a/test/UpdateCheck.cpp
+++ b/test/UpdateCheck.cpp
@@ -49,17 +49,17 @@
protected:
AdblockPlus::AppInfo appInfo;
TestWebRequest* webRequest;
AdblockPlus::WebRequestPtr webRequestPtr;
AdblockPlus::JsEnginePtr jsEngine;
FilterEnginePtr filterEngine;
bool eventCallbackCalled;
- AdblockPlus::JsValueList eventCallbackParams;
+ AdblockPlus::JsConstValueList eventCallbackParams;
bool updateCallbackCalled;
std::string updateError;
void SetUp()
{
webRequest = new TestWebRequest();
webRequestPtr.reset(webRequest);
@@ -81,17 +81,17 @@
}
void ForceUpdateCheck()
{
filterEngine->ForceUpdateCheck(
std::bind(&UpdateCheckTest::UpdateCallback, this, std::placeholders::_1));
}
- void EventCallback(const AdblockPlus::JsValueList& params)
+ void EventCallback(const AdblockPlus::JsConstValueList& params)
{
eventCallbackCalled = true;
eventCallbackParams = params;
}
void UpdateCallback(const std::string& error)
{
updateCallbackCalled = true;
« include/AdblockPlus/JsValue.h ('K') | « test/JsEngine.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld