Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/FilterEngine.h

Issue 29410664: Issue 5013 - Use const JsValue and pass reference where applicable (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Fixed comment Created April 13, 2017, 3:45 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/FilterEngine.h
===================================================================
--- a/include/AdblockPlus/FilterEngine.h
+++ b/include/AdblockPlus/FilterEngine.h
@@ -529,22 +529,22 @@
int updateCheckId;
static const std::map<ContentType, std::string> contentTypes;
explicit FilterEngine(const JsEnginePtr& jsEngine);
FilterPtr CheckFilterMatch(const std::string& url,
ContentTypeMask contentTypeMask,
const std::string& documentUrl) const;
- void UpdateAvailable(const UpdateAvailableCallback& callback, const JsValueList& params) const;
+ void UpdateAvailable(const UpdateAvailableCallback& callback, const JsConstValueList& params) const;
void UpdateCheckDone(const std::string& eventName,
- const UpdateCheckDoneCallback& callback, const JsValueList& params);
- void FilterChanged(const FilterChangeCallback& callback, const JsValueList& params) const;
+ const UpdateCheckDoneCallback& callback, const JsConstValueList& params);
+ void FilterChanged(const FilterChangeCallback& callback, const JsConstValueList& params) const;
void ShowNotification(const ShowNotificationCallback& callback,
- const JsValueList& params) const;
+ const JsConstValueList& param) const;
FilterPtr GetWhitelistingFilter(const std::string& url,
ContentTypeMask contentTypeMask, const std::string& documentUrl) const;
FilterPtr GetWhitelistingFilter(const std::string& url,
ContentTypeMask contentTypeMask,
const std::vector<std::string>& documentUrls) const;
};
}
« no previous file with comments | « no previous file | include/AdblockPlus/JsEngine.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld