Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Side by Side Diff: new-options.html

Issue 29411555: Issue 5169 - Add whitelisted tab to the new options page (Closed)
Patch Set: Addressed latest comments Created May 22, 2017, 9:35 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« locale/en-US/new-options.json ('K') | « locale/en-US/new-options.json ('k') | new-options.js » ('j') | new-options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-2017 eyeo GmbH 4 - Copyright (C) 2006-2017 eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 29 matching lines...) Expand all
40 40
41 <nav> 41 <nav>
42 <ul id="nav-tablist" class="tabs vertical" 42 <ul id="nav-tablist" class="tabs vertical"
43 role="tablist" data-action="switch-tab" 43 role="tablist" data-action="switch-tab"
44 data-keys="ArrowLeft ArrowUp ArrowRight ArrowDown"> 44 data-keys="ArrowLeft ArrowUp ArrowRight ArrowDown">
45 <li id="tab-general" role="tab" data-tab="general" 45 <li id="tab-general" role="tab" data-tab="general"
46 aria-selected="true" aria-controls="content-general" 46 aria-selected="true" aria-controls="content-general"
47 tabindex="0"> 47 tabindex="0">
48 <span class="i18n_options_tab_general"></span> 48 <span class="i18n_options_tab_general"></span>
49 </li> 49 </li>
50 <li id="tab-whitelist" role="tab" data-tab="whitelist"
51 aria-controls="content-whitelist"
52 tabindex="-1">
53 <span class="i18n_options_tab_whitelist"></span>
54 </li>
50 <li id="tab-advanced" role="tab" data-tab="advanced" 55 <li id="tab-advanced" role="tab" data-tab="advanced"
51 data-subtab="advanced-allFilterLists" 56 data-subtab="advanced-allFilterLists"
52 aria-controls="content-advanced" tabindex="-1"> 57 aria-controls="content-advanced" tabindex="-1">
53 <span class="i18n_options_tab_advanced"></span> 58 <span class="i18n_options_tab_advanced"></span>
54 </li> 59 </li>
55 <li id="tab-help" role="tab" data-tab="help" 60 <li id="tab-help" role="tab" data-tab="help"
56 aria-controls="content-help" tabindex="-1"> 61 aria-controls="content-help" tabindex="-1">
57 <span class="i18n_options_tab_help"></span> 62 <span class="i18n_options_tab_help"></span>
58 </li> 63 </li>
59 </ul> 64 </ul>
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 data-tooltip="options_acceptableAds_title_tooltip" 158 data-tooltip="options_acceptableAds_title_tooltip"
154 data-tooltip-image="skin/tooltips/acceptable-ads.png"></sp an> 159 data-tooltip-image="skin/tooltips/acceptable-ads.png"></sp an>
155 </div> 160 </div>
156 <ul id="acceptableads-table" class="table list"> 161 <ul id="acceptableads-table" class="table list">
157 <template> 162 <template>
158 <button data-action="toggle-remove-subscription" role="check box" class="control"></button> 163 <button data-action="toggle-remove-subscription" role="check box" class="control"></button>
159 <label class="display"></label> 164 <label class="display"></label>
160 </template> 165 </template>
161 </ul> 166 </ul>
162 </div> 167 </div>
163 <div id="whitelisting">
164 <div class="option-name">
165 <strong class="i18n_options_whitelisted_title"></strong>
166 <span class="i18n_options_readMore"
167 data-tooltip="options_whitelisted_title_tooltip"
168 data-tooltip-image="skin/tooltips/whitelisted.png"
169 data-tooltip-flip="horizontal"></span>
170 </div>
171 <ul id="whitelisting-table" class="table list">
172 <template>
173 <label class="display"></label>
174 <button data-action="remove-filter" class="delete control" t itle="options_control_remove_title"></button>
175 </template>
176 </ul>
177 <div class="controls">
178 <button data-action="edit-domain-exception">
179 <span class="icon icon-add"></span>
180 <span class="i18n_options_whitelisted_add"></span>
181 </button>
182 <div>
183 <span class="icon icon-add" data-action="add-domain-exceptio n"></span>
184 <input type="text" id="whitelisting-textbox" placeholder="ww w.example.com" />
185 <span class="icon icon-enter" data-action="add-domain-except ion"></span>
186 </div>
187 <div>
188 <button id="whitelisting-add-button" class="button-add" data -action="add-domain-exception">
189 +<span class="i18n_options_button_add"></span>
190 </button>
191 <span></span>
192 <button class="i18n_options_button_cancel cancel-button" dat a-action="cancel-domain-exception"></button>
193 </div>
194 </div>
195 </div>
196 </div> 168 </div>
197 </div> 169 </div>
198 </div> 170 </div>
199 171
172 <!-- Whitelist tab content -->
173 <div id="content-whitelist" role="tabpanel" aria-labelledby="tab-whiteli st">
174 <h1 class="i18n_options_tab_whitelist"></h1>
175 <p class="i18n_options_whitelist_description"></p>
176 <form action="">
Thomas Greiner 2017/05/26 11:10:39 Detail: Do we need the "action" attribute? We'll n
saroyanm 2017/05/31 08:30:26 Done.
saroyanm 2017/05/31 08:30:26 Interesting MDN still uses empty action attribute
177 <input id="whitelisting-textbox" type="text">
178 <button id="whitelisting-add-button"
179 type="submit"
180 data-action="add-domain-exception"
181 class="i18n_options_whitelist_add" disabled>
182 </button>
183 <div id="whitelisting-validation"></div>
184 </form>
185 <ul id="whitelisting-table" class="table list">
186 <template>
187 <label class="display"></label>
188 <button data-action="remove-filter" class="delete control"
189 title="options_control_remove_title">
190 </button>
191 </template>
192 </ul>
193 </div>
194
200 <!-- Advanced tab content --> 195 <!-- Advanced tab content -->
201 <div id="content-advanced" role="tabpanel" 196 <div id="content-advanced" role="tabpanel"
202 aria-labelledby="tab-advanced"> 197 aria-labelledby="tab-advanced">
203 <div> 198 <div>
204 <h1 class="i18n_options_tweaks_title"></h1> 199 <h1 class="i18n_options_tweaks_title"></h1>
205 <ul id="tweaks" class="table"> 200 <ul id="tweaks" class="table">
206 <li data-pref="shouldShowBlockElementMenu"> 201 <li data-pref="shouldShowBlockElementMenu">
207 <label> 202 <label>
208 <button role="checkbox" data-action="toggle-pref"></button> 203 <button role="checkbox" data-action="toggle-pref"></button>
209 <span class="i18n_options_tweaks_blockElement"></span> 204 <span class="i18n_options_tweaks_blockElement"></span>
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 <div class="url"></div> 413 <div class="url"></div>
419 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> 414 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button>
420 </div> 415 </div>
421 </div> 416 </div>
422 </div> 417 </div>
423 <!-- Placeholder element to determine when to wrap focus around --> 418 <!-- Placeholder element to determine when to wrap focus around -->
424 <span class="focus-last" tabindex="0"></span> 419 <span class="focus-last" tabindex="0"></span>
425 </div> 420 </div>
426 </body> 421 </body>
427 </html> 422 </html>
OLDNEW
« locale/en-US/new-options.json ('K') | « locale/en-US/new-options.json ('k') | new-options.js » ('j') | new-options.js » ('J')

Powered by Google App Engine
This is Rietveld