Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: new-options.html

Issue 29411555: Issue 5169 - Add whitelisted tab to the new options page (Closed)
Left Patch Set: Created April 21, 2017, 11:32 a.m.
Right Patch Set: Fixed the TYPO Created July 3, 2017, 4:10 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « locale/en-US/new-options.json ('k') | new-options.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-2017 eyeo GmbH 4 - Copyright (C) 2006-2017 eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 152 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 <button data-action="toggle-remove-subscription" role="check box" class="control"></button> 163 <button data-action="toggle-remove-subscription" role="check box" class="control"></button>
164 <label class="display"></label> 164 <label class="display"></label>
165 </template> 165 </template>
166 </ul> 166 </ul>
167 </div> 167 </div>
168 </div> 168 </div>
169 </div> 169 </div>
170 </div> 170 </div>
171 171
172 <!-- Whitelist tab content --> 172 <!-- Whitelist tab content -->
173 <div id="content-whitelist" role="tabpanel" aria-labelledby="tab-help"> 173 <div id="content-whitelist" role="tabpanel" aria-labelledby="tab-whiteli st">
Thomas Greiner 2017/05/09 13:42:56 The content of "aria-labelledby" is referring to t
saroyanm 2017/05/16 20:20:06 Done.
174 <h1 class="i18n_options_whitelist_title"></h1> 174 <h1 class="i18n_options_tab_whitelist"></h1>
175 <p class="i18n_options_whitelist_description"></p> 175 <p class="i18n_options_whitelist_description"></p>
176 <hr> 176 <form>
Thomas Greiner 2017/05/09 13:42:55 This is merely a cosmetic element so let's use CSS
saroyanm 2017/05/16 20:20:06 Looking through the designs and checking the docum
177 <div>
saroyanm 2017/04/21 12:03:17 I think this should be a <form> element and button
Thomas Greiner 2017/05/09 13:42:56 Yep, we can tackle this separately in the future.
saroyanm 2017/05/16 20:20:06 I've created an issue for that -> https://issues.a
178 <input id="whitelisting-textbox" type="text"> 177 <input id="whitelisting-textbox" type="text">
179 <button id="whitelisting-add-button" 178 <button id="whitelisting-add-button"
179 type="submit"
180 data-action="add-domain-exception" 180 data-action="add-domain-exception"
saroyanm 2017/04/21 12:03:17 I think this control element should be changed as
Thomas Greiner 2017/05/09 13:42:56 Makes sense.
181 class="i18n_options_whitelist_add" disabled> 181 class="i18n_options_whitelist_add" disabled>
182 </button> 182 </button>
183 </div> 183 <div id="whitelisting-validation"></div>
184 <div id="whitelisting-validation"></div> 184 </form>
185 <hr>
186 <ul id="whitelisting-table" class="table list"> 185 <ul id="whitelisting-table" class="table list">
187 <template> 186 <template>
188 <label class="display"></label> 187 <label class="display"></label>
189 <button data-action="remove-filter" class="delete control" 188 <button data-action="remove-filter" class="delete control"
190 title="options_control_remove_title"> 189 title="options_control_remove_title">
191 </button> 190 </button>
192 </template> 191 </template>
193 </ul> 192 </ul>
194 </div> 193 </div>
195 194
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 </div> 261 </div>
263 <span class="date"></span> 262 <span class="date"></span>
264 <span class="time"></span> 263 <span class="time"></span>
265 <span class="message"></span> 264 <span class="message"></span>
266 </template> 265 </template>
267 <li class="static"> 266 <li class="static">
268 <button id="own-list" role="checkbox" class="control" aria-c hecked="true" disabled="true"></button> 267 <button id="own-list" role="checkbox" class="control" aria-c hecked="true" disabled="true"></button>
269 <div> 268 <div>
270 <label for="own-list" class="i18n_options_filterList_own_l ist"></label> 269 <label for="own-list" class="i18n_options_filterList_own_l ist"></label>
271 </div> 270 </div>
272 <span data-action="switch-tab,edit-custom-filters" data-tab= "advanced-customFilters"> 271 <span>
273 <a class="i18n_options_filterList_edit_own_list"></a> 272 <a class="i18n_options_filterList_edit_own_list"
273 href="#advanced-customFilters"></a>
274 </span> 274 </span>
275 </li> 275 </li>
276 </ul> 276 </ul>
277 <div class="controls"> 277 <div class="controls">
278 <button data-action="open-dialog" data-dialog="custom"> 278 <button data-action="open-dialog" data-dialog="custom">
279 <span class="icon icon-add"></span> 279 <span class="icon icon-add"></span>
280 <span class="i18n_options_filterList_add"></span> 280 <span class="i18n_options_filterList_add"></span>
281 </button> 281 </button>
282 <button data-action="update-all-subscriptions"> 282 <button data-action="update-all-subscriptions">
283 <span class="icon icon-update"></span> 283 <span class="icon icon-update"></span>
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 <div class="url"></div> 413 <div class="url"></div>
414 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> 414 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button>
415 </div> 415 </div>
416 </div> 416 </div>
417 </div> 417 </div>
418 <!-- Placeholder element to determine when to wrap focus around --> 418 <!-- Placeholder element to determine when to wrap focus around -->
419 <span class="focus-last" tabindex="0"></span> 419 <span class="focus-last" tabindex="0"></span>
420 </div> 420 </div>
421 </body> 421 </body>
422 </html> 422 </html>
LEFTRIGHT

Powered by Google App Engine
This is Rietveld