Issue 5169 - Add whitelisted tab to the new options page

locale/en-US/new-options.json

 {
   "options_page_title": {
     "description": "Options page title",
     "message": "Adblock Plus Options"
   },
   "options_page_header_1": {
     "description": "Page title in navigation sidebar",
     "message": "Options"
   },
   "options_page_header_2": {
     "description": "Name of extension in navigation sidebar",
     "message": "Adblock <strong>Plus</strong>"
   },
   "options_tab_general": {
-    "description": "Name in sidebar for General tab",
+    "description": "Sidebar tab label",
     "message": "General"
   },
   "options_tab_whitelist": {
-    "description": "Name in sidebar for Whitelisted websites tab",
+    "description": "Sidebar tab label and main heading inside corresponding tab",
     "message": "Whitelisted websites"
   },
   "options_tab_advanced": {
-    "description": "Name in sidebar for Advanced tab",
+    "description": "Sidebar tab label",
     "message": "Advanced"
   },
   "options_tab_help": {
-    "description": "Name in sidebar for Help tab",
+    "description": "Sidebar tab label",
     "message": "Help"
   },
   "options_version": {
     "description": "Version label in navigation sidebar",
     "message": "Version"
   },
   "options_tab_share": {
     "description": "Share button in navigation sidebar",
     "message": "Share"
   },
@@ skipping 20 matching lines @@
   "options_language_title": {
     "description": "Ad blocking list option name in General tab",
     "message": "<strong>Adblocking</strong> for websites in..."
   },
   "options_language_title_tooltip_1": {
     "description": "Top part of tooltip description for 'Adblocking' section in General tab",
     "message": "The default filter list is based on your browser's language settings. If you live in Germany, your default filter list is German+English. However, if you live in Germany and frequently visit Italian websites, you need to subscribe to the Italian filter list. To maintain optimal performance, it is recommended to select only the language that you need."
   },
   "options_language_title_tooltip_notes_1": {
     "description": "First bottom part of tooltip description for 'Adblocking' section in General tab",
-    "message": "Consider: Sometimes ads appear because your filter lists are not up to date. If this is the case, it’s recommended to manually update all your filter lists. You can do that by going to <strong>Advanced > Update all filter lists</strong>."
+    "message": "Consider: Sometimes ads appear because your filter lists are not up to date. If this is the case, it's recommended to manually update all your filter lists. You can do that by going to <strong>Advanced > Update all filter lists</strong>."
   },
   "options_language_title_tooltip_notes_2": {
     "description": "Second bottom part of tooltip description for 'Adblocking' section in General tab",
     "message": "If you still see ads, please report them in our Adblock Plus sub-forum under <strong>Help > Forum > Filters for Adblock Plus</strong>."
   },
   "options_language_add": {
     "description": "Add other language button in General Tab",
     "message": "add other website languages"
   },
   "options_more_title": {
@@ skipping 20 matching lines @@
   "options_more_privacy_tooltip_1": {
     "message": "Adblock Plus can disable tracking (e.g. from ad agencies) to further protect your privacy on the web."
   },
   "options_more_privacy_tooltip_2": {
     "message": "Companies such as ad agencies are tracking your online activity and browsing history every time you surf the web. According to Stanford University research, Adblock Plus is the most efficient solution available against third-party tracking companies."
   },
   "options_more_privacy_tooltip_notes_1": {
     "message": "Note that this feature may conflict with Acceptable Ads, which allows some nonintrusive ads to be displayed, as well as the tracking that is needed to measure the performance of those ads. This is necessary because some websites only earn revenue from ads if their impact can be measured."
   },
   "options_more_social_tooltip_1": {
-    "message": "Adblock Plus can disable social media buttons on websites, ensuring that social networks can’t create a profile based on the websites you visit."
+    "message": "Adblock Plus can disable social media buttons on websites, ensuring that social networks can't create a profile based on the websites you visit."
   },
   "options_more_social_tooltip_2": {
     "message": "Buttons used to share content on social media platforms such as Facebook, Twitter, Google Plus and others are placed on almost every website that you visit. Even if you don't click them, these buttons send requests to the servers of the social network which use information to create a profile based on your browsing habits."
   },
   "options_exceptions_title": {
     "description": "Exceptions section name in General tab",
     "message": "Exceptions"
   },
   "options_acceptableAds_title": {
     "description": "Acceptable ads option name in General tab",
     "message": "Acceptable ads"
   },
   "options_acceptableAds_title_tooltip_1": {
     "description": "First part of tooltip description for 'Acceptable Ads' section in General tab",
     "message": "Since many websites rely on advertising revenue, we encourage the use of noninstrusive advertising."
   },
   "options_acceptableAds_title_tooltip_2": {
     "description": "Second part of tooltip description for 'Acceptable Ads' section in General tab",
     "message": "The Acceptable Ads initiative, which supports both users and website owners, is a set of strict guidelines that identifies acceptable ads. Ads meeting these criteria are displayed to users."
   },
   "options_acceptableAds_title_tooltip_3": {
     "description": "Third part of tooltip description for 'Acceptable Ads' section in General tab",
     "message": "You can, however, disable this feature at any time and browse ad-free."
   },
   "options_acceptableAds_description": {
     "description": "Acceptable ads descriptive name in General tab",
     "message": "Allow some non-intrusive advertising"
   },
-  "options_whitelist_title": {
-    "description": "Whitelist tab headline",
-    "message": "Whitelisted websites"

[saroyanm, 2017/05/17 13:15:16]

I think we can reuse, options_tab_whitelist here ?
Probably will need to be renamed and description updated to make it obvious that
the text can be found in couple of places, until we intentionally want to
separate the strings.

[saroyanm, 2017/05/18 16:21:52]

This is a duplication, we should reuse the string.

[saroyanm, 2017/05/22 09:38:23]

Done.

-  },
   "options_whitelist_description": {
     "description": "Whitelist tab description",
-    "message": "You’ve turned off ad blocking on these websites. You will see ads on these websites."
+    "message": "You've turned off ad blocking on these websites. You will see ads on these websites."
   },
   "options_whitelist_add": {
     "description": "Add whitelisted domain button",
     "message": "Add website"
   },
   "options_whitelist_placeholder_example": {
     "description": "Empty Whitelist input placeholder prefix",
     "message": "e.g. $domain$",
     "placeholders": {
       "domain": {
-        "content": "www.example.com"

[saroyanm, 2017/05/16 20:20:07]

Is this solution fine, or we might want to pass the placeholder value in the
code ?

[saroyanm, 2017/05/18 16:21:52]

We will move this placeholder into JS code to make the placeholder reusable in
other places (if needed).

[saroyanm, 2017/05/22 09:38:23]

Done.

+        "content": "$1",
+        "example": "www.example.com"
       }
     }
   },
   "options_whitelist_empty_1": {
     "description": "Empty Whitelist placeholder",
     "message": "You aren't whitelisting any websites yet."
   },
   "options_whitelist_empty_2": {
     "description": "Empty Whitelist placeholder",
     "message": "Websites you trust and want to allow ads on will be shown here."
   },
   "options_whitelist_duplicate": {
     "description": "Duplicate hostname warning of whitelist text input",
     "message": "Website is already whitelisted"
   },
   "options_whitelist_description": {
     "description": "Section description in whitelisted tab",
-    "message": "You’ve turned off ad blocking on these websites. You will see ads on these websites."
+    "message": "You've turned off ad blocking on these websites. You will see ads on these websites."
   },
   "options_button_add": {
     "description": "Add button label",
     "message": "add"
   },
   "options_tweaks_title": {
     "description": "Section title in Advanced tab",
     "message": "Tweaks"
   },
   "options_tweaks_blockElement": {
@@ skipping 258 matching lines @@
   },
   "options_language_ro": {
     "description": "Language name shown in add language modal dialog",
     "message": "Romanian"
   },
   "options_language_ru_uk": {
     "description": "Language name shown in add language modal dialog",
     "message": "Russian and Ukrainian"
   }
 }