Issue 5169 - Add whitelisted tab to the new options page

locale/en-US/new-options.json

Index: locale/en-US/new-options.json
===================================================================
--- a/locale/en-US/new-options.json
+++ b/locale/en-US/new-options.json
@@ -15,6 +15,10 @@
     "description": "Name in sidebar for General tab",
     "message": "General"
   },
+  "options_tab_whitelist": {
+    "description": "Name in sidebar for Whitelisted websites tab",
+    "message": "Whitelisted websites"
+  },
   "options_tab_advanced": {
     "description": "Name in sidebar for Advanced tab",
     "message": "Advanced"
@@ -131,14 +135,46 @@
     "description": "Acceptable ads descriptive name in General tab",
     "message": "Allow some non-intrusive advertising"
   },
+  "options_whitelist_title": {
+    "description": "Whitelist tab headline",
+    "message": "Whitelisted websites"
+  },
+  "options_whitelist_description": {
+    "description": "Whitelist tab description",
+    "message": "You’ve turned off ad blocking on these websites. You will see ads on these websites."
+  },
+  "options_whitelist_add": {
+    "description": "Add whitelisted domain button",
+    "message": "Add website"
+  },
+  "options_whitelist_placeholder_example": {
+    "description": "Empty Whitelist input placeholder prefix",
+    "message": "e.g."

[Thomas Greiner, 2017/05/09 13:42:55]

This assumes that we know where the prefix is placed but it may differ by
language so let's use a placeholder instead.

e.g.
"e.g. $domain$"

That way we can insert the domain at runtime and don't have to worry about where
the "e.g." is positioned in the text.

[saroyanm, 2017/05/16 20:20:06]

Done.

+  },
+  "options_whitelist_empty_1": {
+    "description": "Empty Whitelist placeholder",
+    "message": "You aren't whitelisting any websites yet."
+  },
+  "options_whitelist_empty_2": {
+    "description": "Empty Whitelist placeholder",
+    "message": "Websites you trust and want to allow ads on will be shown here."
+  },
+  "options_whitelist_invalid": {
+    "description": "Invalid hostname notification of whitelist text input",
+    "message": "Not a valid hostname"
+  },
+  "options_whitelist_duplicate": {
+    "description": "Duplicate hostname notification of whitelist text input",

[Thomas Greiner, 2017/05/09 13:42:55]

Detail: "notification" is a bit ambiguous so what about calling it "error
message" or "warning"?

[saroyanm, 2017/05/16 20:20:05]

Done.

+    "message": "Website is already whitelisted"
+  },
+  "options_whitelist_description": {
+    "description": "Section description in whitelisted tab",
+    "message": "You’ve turned off ad blocking on these websites. You will see ads on these websites."
+  },
   "options_whitelisted_add": {

[Thomas Greiner, 2017/05/09 13:42:55]

Detail: This doesn't appear to be used anymore.

[saroyanm, 2017/05/16 20:20:05]

Done.

     "description": "Button label for adding whitelisted website",
     "message": "add website"
   },
-  "options_whitelisted_empty": {
-    "description": "Text shown when list of whitelisted websites is empty",
-    "message": "There are no websites in your whitelist."
-  },
   "options_whitelisted_title": {

[Thomas Greiner, 2017/05/09 13:42:55]

Detail: Those string names should probably be updated for consistenty because
you're no longer calling them "options_whitelisted_*" but "options_whitelist_*".

[saroyanm, 2017/05/16 20:20:06]

Thanks for noticing, this is a duplication.

     "description": "Whitelisting option name in General tab",
     "message": "Whitelisted websites"