Unified Diff: new-options.html
Issue 29411555:
Issue 5169 - Add whitelisted tab to the new options page (Closed)
Patch Set: Addressed Thomas comments
Created May 16, 2017, 8:10 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« locale/en-US/new-options.json ('K')
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
new-options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: new-options.html |
| =================================================================== |
| --- a/new-options.html |
| +++ b/new-options.html |
| @@ -47,6 +47,11 @@ |
| tabindex="0"> |
| <span class="i18n_options_tab_general"></span> |
| </li> |
| + <li id="tab-whitelist" role="tab" data-tab="whitelist" |
| + aria-controls="content-whitelist" |
| + tabindex="-1"> |
| + <span class="i18n_options_tab_whitelist"></span> |
| + </li> |
| <li id="tab-advanced" role="tab" data-tab="advanced" |
| data-subtab="advanced-allFilterLists" |
| aria-controls="content-advanced" tabindex="-1"> |
| @@ -160,43 +165,34 @@ |
| </template> |
| </ul> |
| </div> |
| - <div id="whitelisting"> |
| - <div class="option-name"> |
| - <strong class="i18n_options_whitelisted_title"></strong> |
| - <span class="i18n_options_readMore" |
| - data-tooltip="options_whitelisted_title_tooltip" |
| - data-tooltip-image="skin/tooltips/whitelisted.png" |
| - data-tooltip-flip="horizontal"></span> |
| - </div> |
| - <ul id="whitelisting-table" class="table list"> |
| - <template> |
| - <label class="display"></label> |
| - <button data-action="remove-filter" class="delete control" title="options_control_remove_title"></button> |
| - </template> |
| - </ul> |
| - <div class="controls"> |
| - <button data-action="edit-domain-exception"> |
| - <span class="icon icon-add"></span> |
| - <span class="i18n_options_whitelisted_add"></span> |
| - </button> |
| - <div> |
| - <span class="icon icon-add" data-action="add-domain-exception"></span> |
| - <input type="text" id="whitelisting-textbox" placeholder="www.example.com" /> |
| - <span class="icon icon-enter" data-action="add-domain-exception"></span> |
| - </div> |
| - <div> |
| - <button id="whitelisting-add-button" class="button-add" data-action="add-domain-exception"> |
| - +<span class="i18n_options_button_add"></span> |
| - </button> |
| - <span></span> |
| - <button class="i18n_options_button_cancel cancel-button" data-action="cancel-domain-exception"></button> |
| - </div> |
| - </div> |
| - </div> |
| </div> |
| </div> |
| </div> |
| + <!-- Whitelist tab content --> |
| + <div id="content-whitelist" role="tabpanel" aria-labelledby="tab-whitelist"> |
| + <h1 class="i18n_options_whitelist_title"></h1> |
| + <p class="i18n_options_whitelist_description"></p> |
| + <hr> |
|
saroyanm
2017/05/17 13:35:41
Giving another thought on HR usage, we can use sec
saroyanm
2017/05/17 13:47:48
Nevermind, I think we can iterate this separately,
saroyanm
2017/05/18 16:21:52
Main header and description are not part of the se
saroyanm
2017/05/22 09:38:24
Done.
|
| + <div> |
| + <input id="whitelisting-textbox" type="text"> |
| + <button id="whitelisting-add-button" |
| + data-action="add-domain-exception" |
| + class="i18n_options_whitelist_add" disabled> |
| + </button> |
| + </div> |
| + <div id="whitelisting-validation"></div> |
| + <hr> |
| + <ul id="whitelisting-table" class="table list"> |
| + <template> |
| + <label class="display"></label> |
| + <button data-action="remove-filter" class="delete control" |
| + title="options_control_remove_title"> |
| + </button> |
| + </template> |
| + </ul> |
| + </div> |
| + |
| <!-- Advanced tab content --> |
| <div id="content-advanced" role="tabpanel" |
| aria-labelledby="tab-advanced"> |
« locale/en-US/new-options.json ('K')
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
new-options.js » ('J')
