Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(747)

Issue 29411633: Issue 5136 - Add test for AndroidWebRequestResourceWrapper (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months ago by anton
Modified:
7 months, 1 week ago
CC:
René Jeschke
Visibility:
Public.

Description

Issue 5136 - Add test for AndroidWebRequestResourceWrapper

Patch Set 1 #

Total comments: 23

Patch Set 2 : added "static final" for the test impls #

Total comments: 2

Messages

Total messages: 9
anton
https://codereview.adblockplus.org/29411633/diff/29411634/libadblockplus-android-tests/build.gradle File libadblockplus-android-tests/build.gradle (right): https://codereview.adblockplus.org/29411633/diff/29411634/libadblockplus-android-tests/build.gradle#newcode35 libadblockplus-android-tests/build.gradle:35: res.srcDirs = ['res'] now we need some preloaded subscriptions ...
8 months ago (2017-04-13 13:46:50 UTC) #1
anton
https://codereview.adblockplus.org/29411633/diff/29411634/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java File libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java (right): https://codereview.adblockplus.org/29411633/diff/29411634/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java#newcode121 libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java:121: private void updateSubscriptions() actually it's copy-paste from AdblockEngine but ...
8 months ago (2017-04-13 13:51:41 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29411633/diff/29411634/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java File libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java (right): https://codereview.adblockplus.org/29411633/diff/29411634/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java#newcode43 libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java:43: private class TestRequest extends AndroidWebRequest This inner class can ...
7 months, 2 weeks ago (2017-04-27 18:57:47 UTC) #3
anton
https://codereview.adblockplus.org/29411633/diff/29411634/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java File libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java (right): https://codereview.adblockplus.org/29411633/diff/29411634/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java#newcode43 libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java:43: private class TestRequest extends AndroidWebRequest On 2017/04/27 18:57:46, diegocarloslima ...
7 months, 2 weeks ago (2017-04-28 06:04:49 UTC) #4
anton
https://codereview.adblockplus.org/29411633/diff/29411634/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java File libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java (right): https://codereview.adblockplus.org/29411633/diff/29411634/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java#newcode43 libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java:43: private class TestRequest extends AndroidWebRequest On 2017/04/27 18:57:46, diegocarloslima ...
7 months, 2 weeks ago (2017-04-28 06:10:36 UTC) #5
diegocarloslima
On 2017/04/28 06:10:36, anton wrote: > https://codereview.adblockplus.org/29411633/diff/29411634/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java > File > libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java > (right): > > ...
7 months, 2 weeks ago (2017-04-28 12:53:58 UTC) #6
diegocarloslima
https://codereview.adblockplus.org/29411633/diff/29411634/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java File libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java (right): https://codereview.adblockplus.org/29411633/diff/29411634/libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java#newcode185 libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/AndroidWebRequestResourceWrapperTest.java:185: public void testIntercepted_Easylist() On 2017/04/28 06:04:48, anton wrote: > ...
7 months, 2 weeks ago (2017-04-28 12:54:36 UTC) #7
Felix Dahlke
LGTM with the nit addressed. https://codereview.adblockplus.org/29411633/diff/29424567/libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java File libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java (right): https://codereview.adblockplus.org/29411633/diff/29424567/libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java#newcode142 libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java:142: if (urlWithParams == null) ...
7 months, 1 week ago (2017-05-09 08:10:49 UTC) #8
anton
7 months, 1 week ago (2017-05-10 07:46:54 UTC) #9
Message was sent while issue was closed.
https://codereview.adblockplus.org/29411633/diff/29424567/libadblockplus-andr...
File
libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java
(right):

https://codereview.adblockplus.org/29411633/diff/29424567/libadblockplus-andr...
libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java:142:
if (urlWithParams == null) {
On 2017/05/09 08:10:49, Felix Dahlke wrote:
> Nit: Opening brace should go on its own line.

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5