Issue 5140 - Add tests for settings storage

libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockSettings.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.libadblockplus.android.settings;
 
 import org.adblockplus.libadblockplus.android.Subscription;
 
 import java.io.Serializable;
 import java.util.List;
 
 /**
  * Adblock settings
  */
 public class AdblockSettings implements Serializable
 {
-  private transient boolean adblockEnabled;
-  private transient Boolean acceptableAdsEnabled;
+  private volatile boolean adblockEnabled;

[anton, 2017/04/14 08:14:00]

actually it's a bug fix!
this was meant to be `volatile` as it can be set in UI thread and read in
background thread in AdblockWebView concurrently.

[anton, 2017/04/14 08:15:09]

though the bug did not appear as we don't serialize it in fragments

+  private volatile boolean acceptableAdsEnabled;

[anton, 2017/04/14 08:14:00]

decided to make it primitive.
The original intention was not to introduce logics ('not-/use AA by default')
into the model was it lead to settings this fields required.

   private List<Subscription> subscriptions;
   private List<String> whitelistedDomains;
   private ConnectionType allowedConnectionType;
 
   public boolean isAdblockEnabled()
   {
     return adblockEnabled;
   }
 
   public void setAdblockEnabled(boolean adblockEnabled)
@@ skipping 46 matching lines @@
   {
     return "AdblockSettings{" +
       "adblockEnabled=" + adblockEnabled +
       ", acceptableAdsEnabled=" + acceptableAdsEnabled +
       ", subscriptions:" + (subscriptions != null ? subscriptions.size() : 0) +
       ", whitelistedDomains:" + (whitelistedDomains != null ? whitelistedDomains.size() : 0) +
       ", allowedConnectionType=" + (allowedConnectionType != null ? allowedConnectionType.getValue() : "null") +
       '}';
   }
 }