Issue 5145 - Add test for IsAllowedConnectionCallbackImpl

libadblockplus-android-tests/src/org/adblockplus/libadblockplus/tests/IsAllowedConnectionCallbackTest.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 16 matching lines @@
 import org.adblockplus.libadblockplus.android.AndroidWebRequest;
 import org.junit.Test;
 
 import java.util.LinkedList;
 import java.util.List;
 
 public class IsAllowedConnectionCallbackTest extends BaseJsTest
 {
   private static final int UPDATE_SUBSCRIPTIONS_WAIT_DELAY_MS = 5 * 1000; // 5s
 
-  private class TestRequest extends AndroidWebRequest

[diegocarloslima, 2017/04/27 19:04:58]

This inner class can be static

[anton, 2017/04/28 06:16:23]

not sure this is a significant and really required change.
uploaded new patch set

+  private static final class TestRequest extends AndroidWebRequest
   {
     private List<String> urls = new LinkedList<String>();
 
     public List<String> getUrls()
     {
       return urls;
     }
 
     @Override
     public ServerResponse httpGET(String url, List<HeaderEntry> headers)
     {
       urls.add(url);
       return super.httpGET(url, headers);
     }
   }
 
-  private class TestCallback extends IsAllowedConnectionCallback

[diegocarloslima, 2017/04/27 19:04:58]

This inner class can be static

[anton, 2017/04/28 06:16:23]

Acknowledged.

+  private static final class TestCallback extends IsAllowedConnectionCallback
   {
     private boolean result;
     private boolean invoked;
     private String connectionType;
 
     public boolean isResult()
     {
       return result;
     }
 
@@ skipping 85 matching lines @@
     updateSubscriptions();
     SystemClock.sleep(UPDATE_SUBSCRIPTIONS_WAIT_DELAY_MS);
 
     assertTrue(callback.isInvoked());
     assertNotNull(callback.getConnectionType());
     assertEquals(allowedConnectionType, callback.getConnectionType());
 
     assertEquals(0, request.getUrls().size());
   }
 }