Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(373)

Issue 29415555: Issue 5148 - Remove Apache String Utils code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months ago by anton
Modified:
7 months, 2 weeks ago
CC:
René Jeschke
Visibility:
Public.

Description

Issue 5148 - Remove Apache String Utils code

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6500 lines) Patch
M libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java View 1 chunk +0 lines, -39 lines 2 comments Download
D libadblockplus-android/src/org/apache/commons/lang/CharUtils.java View 1 chunk +0 lines, -611 lines 0 comments Download
D libadblockplus-android/src/org/apache/commons/lang/StringEscapeUtils.java View 1 chunk +0 lines, -680 lines 0 comments Download
D libadblockplus-android/src/org/apache/commons/lang/StringUtils.java View 1 chunk +0 lines, -5170 lines 0 comments Download

Messages

Total messages: 3
anton
https://codereview.adblockplus.org/29415555/diff/29415556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java File libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java (left): https://codereview.adblockplus.org/29415555/diff/29415556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java#oldcode42 libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java:42: public static String capitalizeString(final String s) not used https://codereview.adblockplus.org/29415555/diff/29415556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java#oldcode54 ...
8 months ago (2017-04-17 07:12:47 UTC) #1
diegocarloslima
On 2017/04/17 07:12:47, anton wrote: > https://codereview.adblockplus.org/29415555/diff/29415556/libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java > File > libadblockplus-android/src/org/adblockplus/libadblockplus/android/Utils.java > (left): > > ...
7 months, 3 weeks ago (2017-04-27 13:59:27 UTC) #2
Felix Dahlke
7 months, 2 weeks ago (2017-04-28 09:15:02 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5