Issue 5153 - Simplify patterns.ini parsing

test/filterStorage_readwrite.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 118 matching lines @@
 exports.testReadAndSaveToFile = function(test)
 {
   testReadWrite(test, false);
 };
 
 exports.testReadAndSaveToFileWithExternalSubscription = function(test)
 {
   testReadWrite(test, true);
 };
 
-exports.testLegacyGroups = {};
-
-for (let url of ["~wl~", "~fl~", "~eh~"])
-{
-  exports.testLegacyGroups["read empty " + url] = function(test)
-  {
-    IO._setFileContents(FilterStorage.sourceFile, [
-      "[Subscription]", "url=" + url
-    ]);
-
-    FilterStorage.loadFromDisk().then(() =>
-    {
-      test.equal(FilterStorage.subscriptions.length, 0, "Number of filter subscriptions");
-    }).catch(unexpectedError.bind(test)).then(() => test.done());
-  };
-
-  exports.testLegacyGroups["read non-empty " + url] = function(test)
-  {
-    IO._setFileContents(FilterStorage.sourceFile, [
-      "[Subscription]", "url=" + url,
-      "[Subscription filters]", "foo"
-    ]);
-
-    FilterStorage.loadFromDisk().then(() =>
-    {
-      test.equal(FilterStorage.subscriptions.length, 1, "Number of filter subscriptions");
-      if (FilterStorage.subscriptions.length == 1)
-      {
-        let subscription = FilterStorage.subscriptions[0];
-        test.equal(subscription.url, url, "Subscription ID");
-        test.equal(subscription.title, null, "Subscription title");
-        test.deepEqual(subscription.defaults, null, "Default types");
-        test.equal(subscription.filters.length, 1, "Number of subscription filters");
-        if (subscription.filters.length == 1)
-          test.equal(subscription.filters[0].text, "foo", "First filter");
-      }
-    }).catch(unexpectedError.bind(test)).then(() => test.done());
-  };
-}
-
-exports.testReadLegacyFilters = function(test)
-{
-  IO._setFileContents(FilterStorage.sourceFile, [
-    "[Subscription]", "url=~user~1234", "title=Foo",
-    "[Subscription filters]",
-    "[User patterns]", "foo", "\\[bar]", "foo#bar"
-  ]);
-
-  FilterStorage.loadFromDisk().then(() =>
-  {
-    test.equal(FilterStorage.subscriptions.length, 1, "Number of filter subscriptions");
-    if (FilterStorage.subscriptions.length == 1)
-    {
-      let subscription = FilterStorage.subscriptions[0];
-      test.equal(subscription.filters.length, 3, "Number of subscription filters");
-      if (subscription.filters.length == 3)
-      {
-        test.equal(subscription.filters[0].text, "foo", "First filter");
-        test.equal(subscription.filters[1].text, "[bar]", "Second filter");
-        test.equal(subscription.filters[2].text, "foo#bar", "Third filter");
-      }
-    }
-  }).catch(unexpectedError.bind(test)).then(() => test.done());
-};
-
 exports.testImportExport = function(test)
 {
   testData.then(lines =>
   {
     if (lines.length && lines[lines.length - 1] == "")
       lines.pop();
 
     let importer = FilterStorage.importData();
     for (let line of lines)
       importer(line);
@@ skipping 94 matching lines @@
     return FilterStorage.restoreBackup(1);
   }).then(() =>
   {
     test.equal(FilterStorage.subscriptions[0].filters.length, 1, "Filter count after restoring backup");
     return FilterStorage.loadFromDisk();
   }).then(() =>
   {
     test.equal(FilterStorage.subscriptions[0].filters.length, 1, "Filter count after reloading");
   }).catch(unexpectedError.bind(test)).then(() => test.done());
 };