Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29416603: Issue 5034 - Part 2: Have NewCallback() return a plain JsValue (Closed)

Created:
April 18, 2017, 9:18 p.m. by hub
Modified:
April 19, 2017, 3:18 p.m.
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/libadblockplus/
Visibility:
Public.

Description

Issue 5034 - Part 2: Have NewCallback() return a plain JsValue

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M include/AdblockPlus/JsEngine.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ConsoleJsObject.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/FileSystemJsObject.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/GlobalJsObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/JsEngine.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/WebRequestJsObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
hub
April 18, 2017, 9:18 p.m. (2017-04-18 21:18:29 UTC) #1
sergei
April 19, 2017, 10:25 a.m. (2017-04-19 10:25:23 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld