src/ConsoleJsObject.cpp - Issue 29416603: Issue 5034 - Part 2: Have NewCallback() return a plain JsValue

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/ConsoleJsObject.cpp

Issue 29416603: Issue 5034 - Part 2: Have NewCallback() return a plain JsValue (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Patch Set: Created April 18, 2017, 9:18 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: src/ConsoleJsObject.cpp

===================================================================

--- a/src/ConsoleJsObject.cpp

+++ b/src/ConsoleJsObject.cpp

@@ -102,16 +102,16 @@

(*callback)(AdblockPlus::LogSystem::LOG_LEVEL_TRACE, traceback.str(), "");

return v8::Undefined();

}

AdblockPlus::JsValue& AdblockPlus::ConsoleJsObject::Setup(

AdblockPlus::JsEngine& jsEngine, AdblockPlus::JsValue& obj)

{

- obj.SetProperty("log", *jsEngine.NewCallback(::LogCallback));

- obj.SetProperty("debug", *jsEngine.NewCallback(::DebugCallback));

- obj.SetProperty("info", *jsEngine.NewCallback(::InfoCallback));

- obj.SetProperty("warn", *jsEngine.NewCallback(::WarnCallback));

- obj.SetProperty("error", *jsEngine.NewCallback(::ErrorCallback));

- obj.SetProperty("trace", *jsEngine.NewCallback(::TraceCallback));

+ obj.SetProperty("log", jsEngine.NewCallback(::LogCallback));

+ obj.SetProperty("debug", jsEngine.NewCallback(::DebugCallback));

+ obj.SetProperty("info", jsEngine.NewCallback(::InfoCallback));

+ obj.SetProperty("warn", jsEngine.NewCallback(::WarnCallback));

+ obj.SetProperty("error", jsEngine.NewCallback(::ErrorCallback));

+ obj.SetProperty("trace", jsEngine.NewCallback(::TraceCallback));

return obj;

}

« no previous file with comments | « include/AdblockPlus/JsEngine.h ('k') | src/FileSystemJsObject.cpp » ('j') | no next file with comments »