Issue 5161 - Use maps and sets where appropriate

lib/popupBlocker.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /** @module popupBlocker */
 
 "use strict";
 
 const {defaultMatcher} = require("matcher");
 const {BlockingFilter, RegExpFilter} = require("filterClasses");
 const {stringifyURL, isThirdParty, extractHostFromFrame} = require("url");
 const {checkWhitelisted} = require("whitelisting");
 const {logRequest} = require("devtools");
 
 let loadingPopups = new Map();
 
-function hasLoadingPopups()
-{
-  return loadingPopups.size > 0;
-}
-
 function forgetPopup(tabId)
 {
   loadingPopups.delete(tabId);
 
-  if (!hasLoadingPopups())
+  if (loadingPopups.size == 0)
   {
     chrome.webRequest.onBeforeRequest.removeListener(onPopupURLChanged);
     chrome.webNavigation.onCommitted.removeListener(onPopupURLChanged);
     chrome.webNavigation.onCompleted.removeListener(onCompleted);
     chrome.tabs.onRemoved.removeListener(forgetPopup);
   }
 }
 
 function checkPotentialPopup(tabId, popup)
 {
@@ skipping 38 matching lines @@
 }
 
 function onCompleted(details)
 {
   if (details.frameId == 0 && details.url != "about:blank")
     forgetPopup(details.tabId);
 }
 
 chrome.webNavigation.onCreatedNavigationTarget.addListener(details =>
 {
-  if (!hasLoadingPopups())
+  if (loadingPopups.size == 0)
   {
     chrome.webRequest.onBeforeRequest.addListener(
       onPopupURLChanged,
       {
-        urls: ["<all_urls>"],
+        urls: ["http://*/*", "https://*/*"],
         types: ["main_frame"]
       }
     );
     chrome.webNavigation.onCommitted.addListener(onPopupURLChanged);
     chrome.webNavigation.onCompleted.addListener(onCompleted);
     chrome.tabs.onRemoved.addListener(forgetPopup);
   }
 
-  let {tabId} = details;
+  let popup = {
+    url: details.url,
+    sourcePage: new ext.Page({id: details.sourceTabId}),
+    sourceFrame: null
+  };
 
-  let popup = Object.create(null);

[Sebastian Noack, 2017/04/29 22:46:32]

As mentioned before in this review, please don't create objects with no
prototype. Use a literal, unless a Map object is more appropriate.

[Manish Jethani, 2017/05/04 14:47:34]

Done.

-  popup.url = details.url;
-  popup.sourcePage = new ext.Page({id: details.sourceTabId});
-  popup.sourceFrame = null;
-
-  loadingPopups.set(tabId, popup);
+  loadingPopups.set(details.tabId, popup);
 
   let frame = ext.getFrame(details.sourceTabId, details.sourceFrameId);
 
   if (checkWhitelisted(popup.sourcePage, frame))
   {
-    forgetPopup(tabId);
+    forgetPopup(details.tabId);
   }
   else
   {
     popup.sourceFrame = frame;
-    checkPotentialPopup(tabId, popup);
+    checkPotentialPopup(details.tabId, popup);
   }
 });