Issue 5034 - Part 3: Create plain JsValue instead of JsValuePtr

src/JsValue.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 30 matching lines @@
   : jsEngine(src.jsEngine)
 {
   const JsContext context(src.jsEngine);
   value.reset(new v8::Persistent<v8::Value>(src.jsEngine->GetIsolate(), *src.value));
 }
 
 AdblockPlus::JsValue::~JsValue()
 {
   if (value)
   {
-    const JsContext context(jsEngine);

[sergei, 2017/04/20 07:42:52]

I think it deserves a separate commit. Do you mind to do it separately?

[hub, 2017/04/20 12:41:01]

will do.

     value->Dispose();
     value.reset();
   }
 }
 
 JsValue& AdblockPlus::JsValue::operator=(const JsValue& src)
 {
   const JsContext context(src.jsEngine);
   if (value)
     value->Dispose();
@@ skipping 200 matching lines @@
   const v8::TryCatch tryCatch;
   v8::Local<v8::Function> func = v8::Local<v8::Function>::Cast(UnwrapValue());
   v8::Local<v8::Value> result = func->Call(thisObj, args.size(),
     args.size() ? &args[0] : nullptr);
 
   if (tryCatch.HasCaught())
     throw JsError(tryCatch.Exception(), tryCatch.Message());
 
   return JsValue(jsEngine, result);
 }