Issue 5042 - Adds handling for requests which are not associated with browser tab

lib/devtools.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 118 matching lines @@
  *                                 document differs
  * @param {?string}  sitekey       The active sitekey if there is any
  * @param {?boolean} specificOnly  Whether generic filters should be ignored
  * @param {?BlockingFilter} filter The matched filter or null if there is no
  *                                 match
  */
 exports.logRequest = function(page, url, type, docDomain,
                               thirdParty, sitekey,
                               specificOnly, filter)
 {
-  let panel = getActivePanel(page);
-  if (panel)
+  let request = {url, type, docDomain, thirdParty, sitekey, specificOnly};

[Sebastian Noack, 2017/04/21 08:39:53]

Perhaps, we should bail if there are no panels, before we create new objects and
do other stuff, to make sure to keep the overhead as small as possible when the
devtools panel isn't used.

[Jon Sonesen, 2017/04/24 08:40:56]

Acknowledged.

+  if (page)
   {
-    let request = {url, type, docDomain, thirdParty, sitekey, specificOnly};
-    addRecord(panel, request, filter);
+    let panel = getActivePanel(page);
+    if (panel)
+      addRecord(panel, request, filter);
+    return;
   }
+  for (let panelId in panels)

[Sebastian Noack, 2017/04/21 08:39:53]

Some of the code added here, and in this file in general, could be simplified by
turning panels into a Map object, which is also in line with our coding
practices, but back when this code was originally written, the Map object wasn't
supported yet in Chrome. This might be a good opportunity to clean this up.

[Jon Sonesen, 2017/04/24 08:40:56]

Awesome, I agree here. I am wondering though, should I adapt the whole file for
this change or just convert to a map here in the function? I am happy to adapt
the initialization of the panels and the rest of the code path but perhaps it is
better to then open a separate issue?

+    addRecord(panels[panelId], request, filter);

[Sebastian Noack, 2017/04/21 08:39:53]

getActivePanel(), called when logging for a specific page, is excluding panels
of pages that are reloading, we should do the same here.

[Jon Sonesen, 2017/04/24 08:40:56]

Acknowledged.

 };
 
 /**
  * Logs active element hiding filters to the devtools panel.
  *
  * @param {Page}     page       The page the elements were hidden on
  * @param {string[]} selectors  The selectors of applied ElemHideFilters
  * @param {string[]} filters    The text of applied ElemHideEmulationFilters
  * @param {string}   docDomain  The IDN-decoded hostname of the document
  */
@@ skipping 222 matching lines @@
   panels[inspectedTabId] = {port: newPort, records: []};
 });
 
 port.on("devtools.traceElemHide", (message, sender) =>
 {
   logHiddenElements(
     sender.page, message.selectors, message.filters,
     extractHostFromFrame(sender.frame)
   );
 });