Issue 5042 - Adds handling for requests which are not associated with browser tab

lib/requestBlocker.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 51 matching lines @@
     devtools.logRequest(
       page, url, type, docDomain,
       thirdParty, sitekey,
       specificOnly, filter
     );
   }
 }
 
 ext.webRequest.onBeforeRequest.addListener((url, type, page, frame) =>
 {
-  if (checkWhitelisted(page, frame))
-    return true;
+  let docDomain = null;
+  let sitekey = null;
+  let specificOnly = false;
+  let thirdParty = false;
+  let urlString = stringifyURL(url);
 
-  let urlString = stringifyURL(url);
-  let docDomain = extractHostFromFrame(frame);
-  let thirdParty = isThirdParty(url, docDomain);
-  let sitekey = getKey(page, frame);
+  if (frame && page)

[Sebastian Noack, 2017/06/01 17:32:21]

Nit: As mentioned before, I'd add a blank line above, in order to separate the
declarations from the condition.

[Jon Sonesen, 2017/06/02 05:02:58]

Acknowledged.

+  {
+    if (checkWhitelisted(page, frame))
+      return true;
 
-  let specificOnly = !!checkWhitelisted(
-    page, frame, RegExpFilter.typeMap.GENERICBLOCK
-  );
+    docDomain = extractHostFromFrame(frame);
+    sitekey = getKey(page, frame);
+    thirdParty = isThirdParty(url, docDomain);
+    specificOnly = !!checkWhitelisted(page, frame,
+                                      RegExpFilter.typeMap.GENERICBLOCK);
+  }
+

[Sebastian Noack, 2017/06/01 17:32:21]

Nit: One blank line is sufficient here.

[Jon Sonesen, 2017/06/02 05:02:58]

Acknowledged.

+
 
   let mappedType = resourceTypes.get(type) || "OTHER";
 
   let filter = defaultMatcher.matchesAny(
     urlString, RegExpFilter.typeMap[mappedType],
     docDomain, thirdParty, sitekey, specificOnly
   );
 
   setTimeout(onBeforeRequestAsync, 0, page, urlString,
                                       mappedType, docDomain,
@@ skipping 89 matching lines @@
   if (msg.requestType.toUpperCase() in chrome.webRequest.ResourceType)
     return false;
 
   return ext.webRequest.onBeforeRequest._dispatch(
      new URL(msg.url),
      msg.requestType,
      sender.page,
      sender.frame
   ).includes(false);
 });