Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29419555: Noissue - [regression] fix compilation for android (Closed)

Created:
April 21, 2017, 7:53 a.m. by sergei
Modified:
April 21, 2017, 1:54 p.m.
Reviewers:
hub
CC:
Felix Dahlke
Visibility:
Public.

Description

Include paths for android are not configured to include v8.h in tests. Review: https://codereview.adblockplus.org/29419555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M test/JsEngine.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2
sergei
April 21, 2017, 7:54 a.m. (2017-04-21 07:54:30 UTC) #1
hub
April 21, 2017, 11:55 a.m. (2017-04-21 11:55:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld