Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(524)

Issue 29419604: Noissue - Do not redirect modern ABB versions to noelemhide filters (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by f.nicolaisen
Modified:
1 month, 4 weeks ago
Reviewers:
Fred, mathias
CC:
Felix Dahlke, sporz
Base URL:
https://hg1/infrastructure
Visibility:
Public.

Description

Noissue - Do not redirect modern ABB versions to noelemhide filters See http://hub.eyeo.com/issues/735

Patch Set 1 #

Patch Set 2 : improve regexp with escaped dot #

Patch Set 3 : move check down to where it makes sense #

Total comments: 1

Patch Set 4 : improve regexp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M modules/filterserver/files/site.conf View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7
f.nicolaisen
2 months ago (2017-04-21 11:44:18 UTC) #1
f.nicolaisen
PS2 fixes version numbers like 2,7
2 months ago (2017-04-21 13:21:40 UTC) #2
Fred
LGTM
2 months ago (2017-04-21 13:25:01 UTC) #3
f.nicolaisen
New version uploaded that actually works in PS3 :)
2 months ago (2017-04-21 13:45:39 UTC) #4
mathias
https://codereview.adblockplus.org/29419604/diff/29419621/modules/filterserver/files/site.conf File modules/filterserver/files/site.conf (right): https://codereview.adblockplus.org/29419604/diff/29419621/modules/filterserver/files/site.conf#newcode40 modules/filterserver/files/site.conf:40: if ($arg_addonVersion ~ ^(2\.)(7|8|9)($|\.).*$) Why is the major version ...
2 months ago (2017-04-21 14:54:26 UTC) #5
f.nicolaisen
Matze's comments have been addressed in PS4. That is also now live on filter12: curl ...
2 months ago (2017-04-21 15:15:14 UTC) #6
mathias
2 months ago (2017-04-21 15:16:21 UTC) #7
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5