Issue 5163 - Reduce the use of FilterPtr

src/FilterEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 258 matching lines @@
       return contentType.first;
   }
   throw std::invalid_argument("Cannot convert argument to ContentType");
 }
 
 bool FilterEngine::IsFirstRun() const
 {
   return firstRun;
 }
 
-FilterPtr FilterEngine::GetFilter(const std::string& text) const
+Filter FilterEngine::GetFilter(const std::string& text) const
 {
   JsValue func = jsEngine->Evaluate("API.getFilterFromText");
-  return FilterPtr(new Filter(func.Call(jsEngine->NewValue(text))));
+  return Filter(func.Call(jsEngine->NewValue(text)));
 }
 
 SubscriptionPtr FilterEngine::GetSubscription(const std::string& url) const
 {
   JsValue func = jsEngine->Evaluate("API.getSubscriptionFromUrl");
   return SubscriptionPtr(new Subscription(func.Call(jsEngine->NewValue(url))));
 }
 
-std::vector<FilterPtr> FilterEngine::GetListedFilters() const
+std::vector<Filter> FilterEngine::GetListedFilters() const
 {
   JsValue func = jsEngine->Evaluate("API.getListedFilters");
   JsValueList values = func.Call().AsList();
-  std::vector<FilterPtr> result;
+  std::vector<Filter> result;
   for (JsValueList::iterator it = values.begin(); it != values.end(); it++)
-    result.push_back(FilterPtr(new Filter(std::move(*it))));
+    result.push_back(Filter(std::move(*it)));
   return result;
 }
 
 std::vector<SubscriptionPtr> FilterEngine::GetListedSubscriptions() const
 {
   JsValue func = jsEngine->Evaluate("API.getListedSubscriptions");
   JsValueList values = func.Call().AsList();
   std::vector<SubscriptionPtr> result;
   for (JsValueList::iterator it = values.begin(); it != values.end(); it++)
     result.push_back(SubscriptionPtr(new Subscription(std::move(*it))));
@@ skipping 265 matching lines @@
     FilterPtr filter = GetWhitelistingFilter(currentUrl, contentTypeMask, parentUrl);
     if (filter)
     {
       return filter;
     }
     currentUrl = parentUrl;
   }
   while (urlIterator != documentUrls.end());
   return FilterPtr();
 }