Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: include/AdblockPlus/FilterEngine.h

Issue 29419623: Issue 5165 - Remove SubscriptionPtr (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Left Patch Set: Added copy ctor. Don't use = default. Created April 24, 2017, 3:01 p.m.
Right Patch Set: Call the inherited operator Created April 24, 2017, 8:13 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | shell/src/SubscriptionsCommand.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 * use `GetProperty()` to retrieve them by name. 88 * use `GetProperty()` to retrieve them by name.
89 */ 89 */
90 class Subscription : public JsValue, 90 class Subscription : public JsValue,
91 public std::enable_shared_from_this<Subscription> 91 public std::enable_shared_from_this<Subscription>
92 { 92 {
93 friend class FilterEngine; 93 friend class FilterEngine;
94 public: 94 public:
95 /** 95 /**
96 * Copy constructor 96 * Copy constructor
97 */ 97 */
98 Subscription(const Subscription&); 98 Subscription(const Subscription& src);
99 99
100 /** 100 /**
101 * Move constructor 101 * Move constructor
102 */ 102 */
103 Subscription(Subscription&&); 103 Subscription(Subscription&& src);
104 104
105 /** 105 /**
106 * Assignment operator 106 * Assignment operator
107 */ 107 */
108 Subscription& operator=(const Subscription&); 108 Subscription& operator=(const Subscription& src);
sergei 2017/04/24 18:19:36 The same comments as in https://codereview.adblock
hub 2017/04/24 19:16:51 Done.
109
110 /**
111 * Move assignment operator
112 */
113 Subscription& operator=(Subscription&& src);
109 114
110 /** 115 /**
111 * Checks if this subscription has been added to the list of subscriptions. 116 * Checks if this subscription has been added to the list of subscriptions.
112 * @return `true` if this subscription has been added. 117 * @return `true` if this subscription has been added.
113 */ 118 */
114 bool IsListed() const; 119 bool IsListed() const;
115 120
116 /** 121 /**
117 * Adds this subscription to the list of subscriptions. 122 * Adds this subscription to the list of subscriptions.
118 */ 123 */
(...skipping 435 matching lines...) Expand 10 before | Expand all | Expand 10 after
554 const JsValueList& param) const; 559 const JsValueList& param) const;
555 FilterPtr GetWhitelistingFilter(const std::string& url, 560 FilterPtr GetWhitelistingFilter(const std::string& url,
556 ContentTypeMask contentTypeMask, const std::string& documentUrl) const; 561 ContentTypeMask contentTypeMask, const std::string& documentUrl) const;
557 FilterPtr GetWhitelistingFilter(const std::string& url, 562 FilterPtr GetWhitelistingFilter(const std::string& url,
558 ContentTypeMask contentTypeMask, 563 ContentTypeMask contentTypeMask,
559 const std::vector<std::string>& documentUrls) const; 564 const std::vector<std::string>& documentUrls) const;
560 }; 565 };
561 } 566 }
562 567
563 #endif 568 #endif
LEFTRIGHT

Powered by Google App Engine
This is Rietveld