Issue 5165 - Remove SubscriptionPtr

src/FilterEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 59 matching lines @@
 {
   JsValue func = jsEngine->Evaluate("API.removeFilterFromList");
   func.Call(*this);
 }
 
 bool Filter::operator==(const Filter& filter) const
 {
   return GetProperty("text").AsString() == filter.GetProperty("text").AsString();
 }
 
-Subscription::Subscription(const Subscription& subscription)
-  : JsValue(subscription)
-{
-}
-
-Subscription::Subscription(Subscription&& subscription)
-  : JsValue(std::move(subscription))
+Subscription::Subscription(const Subscription& src)
+  : JsValue(src)
+{
+}
+
+Subscription::Subscription(Subscription&& src)
+  : JsValue(std::move(src))
 {
 }
 
 Subscription::Subscription(JsValue&& value)
     : JsValue(std::move(value))
 {
   if (!IsObject())
     throw std::runtime_error("JavaScript value is not an object");
 }
 
-Subscription& Subscription::operator=(const Subscription& subscription)
-{
-  *this = subscription;
+Subscription& Subscription::operator=(const Subscription& src)
+{
+  static_cast<JsValue&>(*this) = src;
+  return *this;
+}
+
+Subscription& Subscription::operator=(Subscription&& src)
+{
+  static_cast<JsValue&>(*this) = std::move(src);
   return *this;
 }
 
 bool Subscription::IsListed() const
 {
   JsValue func = jsEngine->Evaluate("API.isListedSubscription");
   return func.Call(*this).AsBool();
 }
 
 void Subscription::AddToList()
@@ skipping 479 matching lines @@
     FilterPtr filter = GetWhitelistingFilter(currentUrl, contentTypeMask, parentUrl);
     if (filter)
     {
       return filter;
     }
     currentUrl = parentUrl;
   }
   while (urlIterator != documentUrls.end());
   return FilterPtr();
 }