Issue 5164 - Remove NotificationPtr

include/AdblockPlus/Notification.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 34 matching lines @@
     std::string message;
   };
 
   /**
    * Wrapper for an Adblock Plus notification object.
    */
   class Notification: public JsValue,
                       public std::enable_shared_from_this<Notification>
   {
     friend class FilterEngine;
-  protected:
+  public:
     /**
      * Constructor.
      * @param jsValue `JsValue&&` notification JavaScript object.
      */
     explicit Notification(JsValue&& jsValue);

[sergei, 2017/04/21 15:30:33]

I don't think it's a good idea to make this constructor public.

[hub, 2017/04/21 16:29:31]

It was for the tests. I'll find a way.

-  public:
+
     /**
      * Retrieves the type of this notification.
      * @return Type of this notification.
      */
     NotificationType GetType() const;
 
     /**
      * Retrieves the title and message of this notification.
      * @return Translated texts.
      */
     NotificationTexts GetTexts() const;
 
     /**
      * Retrieves the URLs which should be mapped to the links in the message.
      * @return List of links.
      */
     std::vector<std::string> GetLinks() const;
 
     /**
      * Marks this notification as shown. It is only relevant for question
      * notifications. Other notifications are marked automatically.
      */
     void MarkAsShown();
   private:
   };
-  typedef std::shared_ptr<Notification> NotificationPtr;
 }
 
 #endif