Issue 5164 - Remove NotificationPtr

src/FilterEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 514 matching lines @@
 void FilterEngine::ShowNotification(const ShowNotificationCallback& callback,
                                          const JsValueList& params) const
 {
   if (params.size() < 1)
     return;
 
   if (!params[0].IsObject())
   {
     return;
   }
-  callback(NotificationPtr(new Notification(JsValue(params[0]))));
+  auto notification = Notification(JsValue(params[0]));
+  callback(notification);
 }
 
 
 int FilterEngine::CompareVersions(const std::string& v1, const std::string& v2) const
 {
   JsValueList params;
   params.push_back(jsEngine->NewValue(v1));
   params.push_back(jsEngine->NewValue(v2));
   JsValue func = jsEngine->Evaluate("API.compareVersions");
   return func.Call(params).AsInt();
@@ skipping 27 matching lines @@
     FilterPtr filter = GetWhitelistingFilter(currentUrl, contentTypeMask, parentUrl);
     if (filter)
     {
       return filter;
     }
     currentUrl = parentUrl;
   }
   while (urlIterator != documentUrls.end());
   return FilterPtr();
 }