Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: include/AdblockPlus/Notification.h

Issue 29419629: Issue 5164 - Remove NotificationPtr (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Left Patch Set: Added copy ctor Created April 24, 2017, 3:09 p.m.
Right Patch Set: Call the inherited assignment operator properly Created April 24, 2017, 8:16 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « include/AdblockPlus/FilterEngine.h ('k') | src/FilterEngine.cpp » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2017 eyeo GmbH 3 * Copyright (C) 2006-2017 eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 public std::enable_shared_from_this<Notification> 52 public std::enable_shared_from_this<Notification>
53 { 53 {
54 friend class FilterEngine; 54 friend class FilterEngine;
55 protected: 55 protected:
56 /** 56 /**
57 * Constructor. 57 * Constructor.
58 * @param jsValue `JsValue&&` notification JavaScript object. 58 * @param jsValue `JsValue&&` notification JavaScript object.
59 */ 59 */
60 explicit Notification(JsValue&& jsValue); 60 explicit Notification(JsValue&& jsValue);
61 public: 61 public:
62 Notification(const Notification&); 62 /**
sergei 2017/04/24 18:17:53 do you mind adding src arg in the headers for thes
hub 2017/04/24 19:16:23 Done.
63 Notification(Notification&&); 63 * Copy constructor
64 */
65 Notification(const Notification& src);
64 66
65 Notification& operator=(const Notification&); 67 /**
sergei 2017/04/24 18:17:53 What about operator=(Notification&& src)?
hub 2017/04/24 19:16:23 Done.
68 * Move constructor
69 */
70 Notification(Notification&& src);
71
72 /**
73 * Assignment operator
74 */
75 Notification& operator=(const Notification& src);
76
77 /**
78 * Move assignment operator
79 */
80 Notification& operator=(Notification&& src);
66 81
67 /** 82 /**
68 * Retrieves the type of this notification. 83 * Retrieves the type of this notification.
69 * @return Type of this notification. 84 * @return Type of this notification.
70 */ 85 */
71 NotificationType GetType() const; 86 NotificationType GetType() const;
72 87
73 /** 88 /**
74 * Retrieves the title and message of this notification. 89 * Retrieves the title and message of this notification.
75 * @return Translated texts. 90 * @return Translated texts.
76 */ 91 */
77 NotificationTexts GetTexts() const; 92 NotificationTexts GetTexts() const;
78 93
79 /** 94 /**
80 * Retrieves the URLs which should be mapped to the links in the message. 95 * Retrieves the URLs which should be mapped to the links in the message.
81 * @return List of links. 96 * @return List of links.
82 */ 97 */
83 std::vector<std::string> GetLinks() const; 98 std::vector<std::string> GetLinks() const;
84 99
85 /** 100 /**
86 * Marks this notification as shown. It is only relevant for question 101 * Marks this notification as shown. It is only relevant for question
87 * notifications. Other notifications are marked automatically. 102 * notifications. Other notifications are marked automatically.
88 */ 103 */
89 void MarkAsShown(); 104 void MarkAsShown();
90 private: 105 private:
91 }; 106 };
92 } 107 }
93 108
94 #endif 109 #endif
LEFTRIGHT

Powered by Google App Engine
This is Rietveld