Issue 5164 - Remove NotificationPtr

include/AdblockPlus/Notification.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 41 matching lines @@
                       public std::enable_shared_from_this<Notification>
   {
     friend class FilterEngine;
   protected:
     /**
      * Constructor.
      * @param jsValue `JsValue&&` notification JavaScript object.
      */
     explicit Notification(JsValue&& jsValue);
   public:
-    Notification(const Notification&);

[sergei, 2017/04/24 18:17:53]

do you mind adding src arg in the headers for these methods?

[hub, 2017/04/24 19:16:23]

Done.

-    Notification(Notification&&);
+    /**
+     * Copy constructor
+     */
+    Notification(const Notification& src);
 
-    Notification& operator=(const Notification&);

[sergei, 2017/04/24 18:17:53]

What about operator=(Notification&& src)?

[hub, 2017/04/24 19:16:23]

Done.

+    /**
+     * Move constructor
+     */
+    Notification(Notification&& src);
+
+    /**
+     * Assignment operator
+     */
+    Notification& operator=(const Notification& src);
+
+    /**
+     * Move assignment operator
+     */
+    Notification& operator=(Notification&& src);
 
     /**
      * Retrieves the type of this notification.
      * @return Type of this notification.
      */
     NotificationType GetType() const;
 
     /**
      * Retrieves the title and message of this notification.
      * @return Translated texts.
      */
     NotificationTexts GetTexts() const;
 
     /**
      * Retrieves the URLs which should be mapped to the links in the message.
      * @return List of links.
      */
     std::vector<std::string> GetLinks() const;
 
     /**
      * Marks this notification as shown. It is only relevant for question
      * notifications. Other notifications are marked automatically.
      */
     void MarkAsShown();
   private:
   };
 }
 
 #endif