Unified Diff: src/FilterEngine.cpp
Issue 29419629:
Issue 5164 - Remove NotificationPtr (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Fix test, reconsolidate lambdas as per review
Created April 21, 2017, 6:37 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« include/AdblockPlus/Notification.h ('k')
|
test/Notification.cpp » ('j')
|
test/Notification.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: src/FilterEngine.cpp |
| =================================================================== |
| --- a/src/FilterEngine.cpp |
| +++ b/src/FilterEngine.cpp |
| @@ -527,17 +527,18 @@ |
| { |
| if (params.size() < 1) |
| return; |
| if (!params[0].IsObject()) |
| { |
| return; |
| } |
| - callback(NotificationPtr(new Notification(JsValue(params[0])))); |
| + auto notification = Notification(JsValue(params[0])); |
| + callback(notification); |
| } |
| int FilterEngine::CompareVersions(const std::string& v1, const std::string& v2) const |
| { |
| JsValueList params; |
| params.push_back(jsEngine->NewValue(v1)); |
| params.push_back(jsEngine->NewValue(v2)); |
« no previous file with comments
|
« include/AdblockPlus/Notification.h ('k')
|
test/Notification.cpp » ('j')
|
test/Notification.cpp » ('J')
