Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/FilterEngine.h

Issue 29419629: Issue 5164 - Remove NotificationPtr (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Added move ctor. Test fixes. Created April 24, 2017, 1:54 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/AdblockPlus/Notification.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/FilterEngine.h
===================================================================
--- a/include/AdblockPlus/FilterEngine.h
+++ b/include/AdblockPlus/FilterEngine.h
@@ -210,17 +210,17 @@
* Container of name-value pairs representing a set of preferences.
*/
typedef std::map<std::string, AdblockPlus::JsValue> Prefs;
/**
* Callback type invoked when a new notification should be shown.
* The parameter is the Notification object to be shown.
*/
- typedef std::function<void(const NotificationPtr&)> ShowNotificationCallback;
+ typedef std::function<void(Notification&)> ShowNotificationCallback;
/**
* Callback function returning false when current connection is not
* allowedConnectionType, e.g. because it is a metered connection.
*/
typedef std::function<bool(const std::string* allowedConnectionType)> IsConnectionAllowedCallback;
/**
« no previous file with comments | « no previous file | include/AdblockPlus/Notification.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld