Unified Diff: include/AdblockPlus/Notification.h
Issue 29419629:
Issue 5164 - Remove NotificationPtr (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Added copy ctor
Created April 24, 2017, 3:09 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« include/AdblockPlus/FilterEngine.h ('k')
|
src/FilterEngine.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: include/AdblockPlus/Notification.h |
| =================================================================== |
| --- a/include/AdblockPlus/Notification.h |
| +++ b/include/AdblockPlus/Notification.h |
| @@ -54,16 +54,21 @@ |
| friend class FilterEngine; |
| protected: |
| /** |
| * Constructor. |
| * @param jsValue `JsValue&&` notification JavaScript object. |
| */ |
| explicit Notification(JsValue&& jsValue); |
| public: |
| + Notification(const Notification&); |
|
sergei
2017/04/24 18:17:53
do you mind adding src arg in the headers for thes
hub
2017/04/24 19:16:23
Done.
|
| + Notification(Notification&&); |
| + |
| + Notification& operator=(const Notification&); |
|
sergei
2017/04/24 18:17:53
What about operator=(Notification&& src)?
hub
2017/04/24 19:16:23
Done.
|
| + |
| /** |
| * Retrieves the type of this notification. |
| * @return Type of this notification. |
| */ |
| NotificationType GetType() const; |
| /** |
| * Retrieves the title and message of this notification. |
| @@ -79,12 +84,11 @@ |
| /** |
| * Marks this notification as shown. It is only relevant for question |
| * notifications. Other notifications are marked automatically. |
| */ |
| void MarkAsShown(); |
| private: |
| }; |
| - typedef std::shared_ptr<Notification> NotificationPtr; |
| } |
| #endif |
« no previous file with comments
|
« include/AdblockPlus/FilterEngine.h ('k')
|
src/FilterEngine.cpp » ('j')
|
no next file with comments »
