Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/Notification.cpp

Issue 29419629: Issue 5164 - Remove NotificationPtr (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set: Added copy ctor Created April 24, 2017, 3:09 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/Notification.cpp
===================================================================
--- a/src/Notification.cpp
+++ b/src/Notification.cpp
@@ -52,21 +52,37 @@
if (notificationTypeIterator == notificationTypes.end())
{
return NotificationType::NOTIFICATION_TYPE_INFORMATION;
}
return notificationTypeIterator->first;
}
}
+Notification::Notification(const Notification& notification)
+ : JsValue(notification)
+{
+}
+
+Notification::Notification(Notification&& notification)
+ : JsValue(std::move(notification))
+{
+}
+
Notification::Notification(JsValue&& jsValue)
: JsValue(std::move(jsValue))
{
}
+Notification& Notification::operator=(const Notification& notification)
+{
+ *this = notification;
+ return *this;
+}
+
NotificationType Notification::GetType() const
{
return StringToNotificationType(GetProperty("type").AsString());
}
NotificationTexts Notification::GetTexts() const
{
JsValue jsTexts = jsEngine->Evaluate("API.getNotificationTexts").Call(*this);

Powered by Google App Engine
This is Rietveld