Issue 29420565: Noissue - Remove some dead code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29420565: Noissue - Remove some dead code (Closed)

Created:
April 24, 2017, 9:43 a.m. by Wladimir Palant

Modified:
April 24, 2017, 9:52 a.m.

Reviewers:
Sebastian Noack

Base URL:
https://hg.adblockplus.org/buildtools

Visibility:
Public.

Description

Jakub Wilk noticed that we are using re.sub() incorrectly in some places - passing flags parameter by position, yet this position is interpreted as count instead. I looked a bit closer, and both occasions are actually dead code. Functions appendToFile() and removeFromFile() are simply not being called any more. And fixAbsoluteUrls() hack in the Safari packager is unnecessary, we no longer have any absolute URLs. Verified that the builds are identical with this change applied.

Patch Set 1 #

Created: April 24, 2017, 9:43 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -33 lines)			Patch
	M	localeTools.py	View		1 chunk	+0 lines, -21 lines	0 comments	Download
	M	packagerSafari.py	View		2 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages