Unified Diff: python/mozbuild/mozbuild/android_version_code.py
Issue 29420569:
Issue 5170 - Force usage of Android version code v0 function (Closed)
Patch Set:
Created April 24, 2017, 9:55 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: python/mozbuild/mozbuild/android_version_code.py |
| =================================================================== |
| --- a/python/mozbuild/mozbuild/android_version_code.py |
| +++ b/python/mozbuild/mozbuild/android_version_code.py |
| @@ -122,17 +122,19 @@ def android_version_code_v1(buildid, cpu |
| else: |
| raise ValueError("Don't know how to compute android:versionCode " |
| "for CPU arch %s" % cpu_arch) |
| return version |
| def android_version_code(buildid, *args, **kwargs): |
| base = int(str(buildid)) |
| - if base < V1_CUTOFF: |
| + # Forcing the usage of v0 function |
| + # See https://issues.adblockplus.org/ticket/5170 |
| + if True: |
| return android_version_code_v0(buildid, *args, **kwargs) |
| else: |
| return android_version_code_v1(buildid, *args, **kwargs) |
|
anton
2017/04/24 09:59:02
minor Q: why not just remove it? ok if left for av
|
| def main(argv): |
| parser = argparse.ArgumentParser('Generate an android:versionCode', |
| add_help=False) |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
