Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(102)

Issue 29420575: Issue 5171 - Fix automation to update subscriptions.xml (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by Wladimir Palant
Modified:
2 years, 10 months ago
Reviewers:
Vasily Kuznetsov
CC:
Thomas Greiner
Base URL:
https://hg.adblockplus.org/sitescripts/
Visibility:
Public.

Description

Issue 5171 - Fix automation to update subscriptions.xml

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed example configuration #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M .sitescripts.example View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sitescripts/extensions/bin/updateRecommendations.py View 1 chunk +19 lines, -10 lines 0 comments Download
M tox.ini View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
2 years, 10 months ago (2017-04-24 12:06:21 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29420575/diff/29420576/sitescripts/extensions/bin/updateRecommendations.py File sitescripts/extensions/bin/updateRecommendations.py (right): https://codereview.adblockplus.org/29420575/diff/29420576/sitescripts/extensions/bin/updateRecommendations.py#newcode26 sitescripts/extensions/bin/updateRecommendations.py:26: path = get_config().get('extensions', 'subscriptions_path').split('/') For reference: we never updated ...
2 years, 10 months ago (2017-04-24 12:08:11 UTC) #2
Wladimir Palant
Patch Set 2 fixes example configuration - the copy actually being used lives in adblockpluscore, ...
2 years, 10 months ago (2017-04-24 12:19:21 UTC) #3
Vasily Kuznetsov
2 years, 10 months ago (2017-04-25 10:32:57 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5