Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29420608: Issue 5006 - Update social blocking list link on ABT tutorials page (Closed)

Created:
April 24, 2017, 4:52 p.m. by juliandoucette
Modified:
June 14, 2017, 11:52 a.m.
Reviewers:
saroyanm
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 5006 - Update social blocking list link on ABT tutorials page

Patch Set 1 #

Patch Set 2 : Updated encoding #

Total comments: 3

Patch Set 3 : Updated using abp_linkfactory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pages/tutorials.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5
juliandoucette
April 24, 2017, 4:52 p.m. (2017-04-24 16:52:28 UTC) #1
juliandoucette
Trivial change. But I'm not 100% sure how abp links work. Can you please have ...
April 24, 2017, 5:02 p.m. (2017-04-24 17:02:01 UTC) #2
saroyanm
https://codereview.adblockplus.org/29420608/diff/29420611/pages/tutorials.html File pages/tutorials.html (right): https://codereview.adblockplus.org/29420608/diff/29420611/pages/tutorials.html#newcode130 pages/tutorials.html:130: {{s42 If you want to block social media buttons ...
June 1, 2017, 12:35 p.m. (2017-06-01 12:35:33 UTC) #3
juliandoucette
Thanks Manvel! New patchset uploaded. https://codereview.adblockplus.org/29420608/diff/29420611/pages/tutorials.html File pages/tutorials.html (right): https://codereview.adblockplus.org/29420608/diff/29420611/pages/tutorials.html#newcode130 pages/tutorials.html:130: {{s42 If you want ...
June 7, 2017, 4:26 p.m. (2017-06-07 16:26:19 UTC) #4
saroyanm
June 13, 2017, 10 a.m. (2017-06-13 10:00:14 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld