Issue 5167 - Update to use libadblockplus revision dca8df9af1a7

libadblockplus-android/jni/JniJsValue.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #ifndef JNIJSVALUE_H
 #define JNIJSVALUE_H
 
 #include <jni.h>
 #include <AdblockPlus/JsValue.h>
 
 void JniJsValue_OnLoad(JavaVM* vm, JNIEnv* env, void* reserved);
 
 void JniJsValue_OnUnload(JavaVM* vm, JNIEnv* env, void* reserved);
 
 jclass GetJsValueClass();
 
-jobject NewJniJsValue(JNIEnv* env, const AdblockPlus::JsValuePtr& jsValue, jclass jsValueClass = 0);
+jobject NewJniJsValue(JNIEnv* env, const AdblockPlus::JsValue& jsValue, jclass jsValueClass = 0);
 
-jobject JniJsValueListToArrayList(JNIEnv* env, AdblockPlus::JsValueList& list);
+jobject JniJsValueListToArrayList(JNIEnv* env, const AdblockPlus::JsValueList& list);
 
-AdblockPlus::JsValue* JniGetJsValue(jlong ptr);
+AdblockPlus::JsValue* JniGetJsValuePtr(jlong ptr);

[anton, 2017/04/26 10:22:59]

as for me it's more logical "..Ptr()" to return pointer and ".." to return an
instance

[sergei, 2017/04/26 14:12:56]

I agree, why is this comment?

[anton, 2017/04/27 06:21:00]

It's just explanation why 2 methods changed the names to each other

 
-AdblockPlus::JsValuePtr& JniGetJsValuePtr(jlong ptr);
+AdblockPlus::JsValue& JniGetJsValue(jlong ptr);
 
 #endif /* JNIJSVALUE_H */