dependencies - Issue 29422558: Issue 5167 - Update to use libadblockplus revision dca8df9af1a7

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: dependencies

Issue 29422558: Issue 5167 - Update to use libadblockplus revision dca8df9af1a7 (Closed)

Left Patch Set: optimizations by serge, using newer libadblockplus-binaries Created May 5, 2017, 11:33 a.m.

Right Patch Set: updated dependencies (..-binaries) Created May 10, 2017, 6:54 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:2f744887c675 git:96b22c9	3 buildtools = buildtools hg:2f744887c675 git:96b22c9

4 libadblockplus-android/jni/libadblockplus-binaries = libadblockplus-binaries hg: a40587693658 git:a528bf6	4 libadblockplus-android/jni/libadblockplus-binaries = libadblockplus-binaries hg: 3d572805cc42 git:da46bc7
sergei 2017/05/08 08:15:14 BTW, I think it makes a little sense to use some s BTW, I think it makes a little sense to use some short version of a commit ID instead of a full version. It's maybe fine so far but I would recommend to use the full one.
LEFT	RIGHT