libadblockplus-android/jni/JniJsValue.h - Issue 29422558: Issue 5167 - Update to use libadblockplus revision dca8df9af1a7

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/jni/JniJsValue.h

Issue 29422558: Issue 5167 - Update to use libadblockplus revision dca8df9af1a7 (Closed)

Patch Set: removed unneeded intermediate variable Created April 26, 2017, 6:57 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: libadblockplus-android/jni/JniJsValue.h

diff --git a/libadblockplus-android/jni/JniJsValue.h b/libadblockplus-android/jni/JniJsValue.h

index d90342d61a8c724db85d85fe0fb1b4b968672795..fa7598c1137104adbc07eb6333d197aecc1b9220 100644

--- a/libadblockplus-android/jni/JniJsValue.h

+++ b/libadblockplus-android/jni/JniJsValue.h

@@ -27,12 +27,12 @@ void JniJsValue_OnUnload(JavaVM* vm, JNIEnv* env, void* reserved);

jclass GetJsValueClass();

-jobject NewJniJsValue(JNIEnv* env, const AdblockPlus::JsValuePtr& jsValue, jclass jsValueClass = 0);

+jobject NewJniJsValue(JNIEnv* env, const AdblockPlus::JsValue& jsValue, jclass jsValueClass = 0);

-jobject JniJsValueListToArrayList(JNIEnv* env, AdblockPlus::JsValueList& list);

+jobject JniJsValueListToArrayList(JNIEnv* env, const AdblockPlus::JsValueList& list);

-AdblockPlus::JsValue* JniGetJsValue(jlong ptr);

+AdblockPlus::JsValue* JniGetJsValuePtr(jlong ptr);

anton 2017/04/26 10:22:59 as for me it's more logical "..Ptr()" to return po

sergei 2017/04/26 14:12:56 I agree, why is this comment?

anton 2017/04/27 06:21:00 It's just explanation why 2 methods changed the na

-AdblockPlus::JsValuePtr& JniGetJsValuePtr(jlong ptr);

+AdblockPlus::JsValue& JniGetJsValue(jlong ptr);

#endif /* JNIJSVALUE_H */