libadblockplus-android/jni/JniCallbacks.h - Issue 29422558: Issue 5167 - Update to use libadblockplus revision dca8df9af1a7

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/jni/JniCallbacks.h

Issue 29422558: Issue 5167 - Update to use libadblockplus revision dca8df9af1a7 (Closed)

Patch Set: optimizations by serge, using newer libadblockplus-binaries Created May 5, 2017, 11:33 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: libadblockplus-android/jni/JniCallbacks.h

diff --git a/libadblockplus-android/jni/JniCallbacks.h b/libadblockplus-android/jni/JniCallbacks.h

index 27269b7cb59419fcc46188a56605d0d60bdc2924..c94024ced7089a40b077719a714b64acc3455d8b 100644

--- a/libadblockplus-android/jni/JniCallbacks.h

+++ b/libadblockplus-android/jni/JniCallbacks.h

@@ -53,7 +53,7 @@ class JniEventCallback : public JniCallbackBase

{

public:

JniEventCallback(JNIEnv* env, jobject callbackObject);

- void Callback(AdblockPlus::JsValueList& params);

+ void Callback(AdblockPlus::JsValueList&& params);

};

class JniUpdateAvailableCallback : public JniCallbackBase

@@ -74,7 +74,7 @@ class JniFilterChangeCallback : public JniCallbackBase

{

public:

JniFilterChangeCallback(JNIEnv* env, jobject callbackObject);

- void Callback(const std::string& arg, const AdblockPlus::JsValuePtr jsValue);

+ void Callback(const std::string& arg, AdblockPlus::JsValue&& jsValue);

};

class JniLogSystemCallback : public JniCallbackBase, public AdblockPlus::LogSystem

@@ -88,7 +88,7 @@ class JniShowNotificationCallback : public JniCallbackBase

{

public:

JniShowNotificationCallback(JNIEnv* env, jobject callbackObject);

- void Callback(const AdblockPlus::NotificationPtr&);

+ void Callback(AdblockPlus::Notification&&);

};

class JniWebRequest : public JniCallbackBase, public AdblockPlus::WebRequest