libadblockplus-android/jni/JniEventCallback.cpp - Issue 29422558: Issue 5167 - Update to use libadblockplus revision dca8df9af1a7

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/jni/JniEventCallback.cpp

Issue 29422558: Issue 5167 - Update to use libadblockplus revision dca8df9af1a7 (Closed)

Patch Set: optimizations by serge, using newer libadblockplus-binaries Created May 5, 2017, 11:33 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: libadblockplus-android/jni/JniEventCallback.cpp

diff --git a/libadblockplus-android/jni/JniEventCallback.cpp b/libadblockplus-android/jni/JniEventCallback.cpp

index 62733e5f91d8dbefba1ed30d6a8fc544a7033041..1601993c738f359f031d36b8733d79324601a572 100644

--- a/libadblockplus-android/jni/JniEventCallback.cpp

+++ b/libadblockplus-android/jni/JniEventCallback.cpp

@@ -36,7 +36,7 @@ JniEventCallback::JniEventCallback(JNIEnv* env, jobject callbackObject)

{

}

-void JniEventCallback::Callback(AdblockPlus::JsValueList& params)

+void JniEventCallback::Callback(AdblockPlus::JsValueList&& params)

{

JNIEnvAcquire env(GetJavaVM());

@@ -47,7 +47,7 @@ void JniEventCallback::Callback(AdblockPlus::JsValueList& params)

if (method)

{

- jobject jsList = JniJsValueListToArrayList(*env, params);

+ jobject jsList = JniJsValueListToArrayList(*env, std::move(params));

env->CallVoidMethod(GetCallbackObject(), method, jsList);

}