Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(780)

Issue 29422615: Issue 5068 - Define translation string format

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 4 weeks ago by juliandoucette
Modified:
2 months ago
CC:
tamara, Jon Sonesen
Visibility:
Public.

Patch Set 1 : First draft #

Total comments: 43
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -0 lines) Patch
A translation-string-format.md View 1 chunk +67 lines, -0 lines 43 comments Download

Messages

Total messages: 15
juliandoucette
3 months, 4 weeks ago (2017-04-26 11:11:34 UTC) #1
juliandoucette
On 2017/04/26 11:11:34, juliandoucette wrote: Done first draft. It's high time we documented this somewhere. ...
3 months, 4 weeks ago (2017-04-26 11:21:21 UTC) #2
juliandoucette
Added a few notes. https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md File translation-string-format.md (right): https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md#newcode25 translation-string-format.md:25: : An identifier context should ...
3 months ago (2017-05-18 08:54:37 UTC) #3
saroyanm
Thanks for starting this Julian. https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md File translation-string-format.md (right): https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md#newcode1 translation-string-format.md:1: # Translation string format ...
2 months, 3 weeks ago (2017-06-01 12:07:26 UTC) #4
juliandoucette
Thanks Manvel :) @Ire, @Lisa, @Winsley your feedback is welcome here too. https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md File translation-string-format.md ...
2 months, 2 weeks ago (2017-06-07 16:07:40 UTC) #5
juliandoucette
Added clarification. https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md File translation-string-format.md (right): https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md#newcode25 translation-string-format.md:25: : An identifier context should describe context ...
2 months, 2 weeks ago (2017-06-07 16:16:18 UTC) #6
ire
https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md File translation-string-format.md (right): https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md#newcode1 translation-string-format.md:1: # Translation string format It would be really helpful ...
2 months, 2 weeks ago (2017-06-08 11:18:34 UTC) #7
juliandoucette
Thanks Ire! https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md File translation-string-format.md (right): https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md#newcode1 translation-string-format.md:1: # Translation string format On 2017/06/08 11:18:34, ...
2 months, 2 weeks ago (2017-06-08 21:07:51 UTC) #8
ire
You're welcome :) https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md File translation-string-format.md (right): https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md#newcode63 translation-string-format.md:63: ### Common uses On 2017/06/08 21:07:51, ...
2 months, 2 weeks ago (2017-06-09 06:50:11 UTC) #9
Lisa
Hi all, Thanks for doing this! Just a couple suggestions from my end: 1. I ...
2 months, 2 weeks ago (2017-06-09 14:14:47 UTC) #10
juliandoucette
Thanks Lisa :) https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md File translation-string-format.md (right): https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md#newcode22 translation-string-format.md:22: : An identifier summary should describe ...
2 months, 2 weeks ago (2017-06-09 15:13:54 UTC) #11
saroyanm
https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md File translation-string-format.md (right): https://codereview.adblockplus.org/29422615/diff/29422620/translation-string-format.md#newcode1 translation-string-format.md:1: # Translation string format On 2017/06/07 16:07:39, juliandoucette wrote: ...
2 months, 1 week ago (2017-06-13 09:48:28 UTC) #12
juliandoucette
@Vasily, @Jon, @Winsley The use of <fix> tags has been a point of contention in ...
2 months, 1 week ago (2017-06-13 11:47:47 UTC) #13
Vasily Kuznetsov
It's hard for me to judge whether <fix> tags are worth the hassle -- I ...
2 months, 1 week ago (2017-06-14 18:07:28 UTC) #14
juliandoucette
2 months ago (2017-06-20 21:14:24 UTC) #15
On 2017/06/14 18:07:28, Vasily Kuznetsov wrote:
> Perhaps we create an issue for this, if this saves a sizable amount of work.

Done. 

https://issues.adblockplus.org/ticket/5340
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5