.eslintrc.json - Issue 29423569: Issue 4796 - Use a modern JS engine in the browser tests and convert all files to ECMAScript 6

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: .eslintrc.json

Issue 29423569: Issue 4796 - Use a modern JS engine in the browser tests and convert all files to ECMAScript 6 (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Left Patch Set: Created April 27, 2017, 11:20 a.m.

Right Patch Set: Addressed some nits Created May 3, 2017, 12:18 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {	1 {

2 "extends": "eslint-config-eyeo",	2 "extends": "eslint-config-eyeo",

3 "root": true,	3 "root": true

4 "parserOptions": {

5 "ecmaVersion": 2017
Wladimir Palant 2017/04/27 11:46:41 This is necessary because our default config won't This is necessary because our default config won't allow async functions. Yes, we need to fix the default. kzar 2017/04/27 15:19:36 Since you're already adding it to the default conf Show quoted text On 2017/04/27 11:46:41, Wladimir Palant wrote: > This is necessary because our default config won't allow async functions. Yes, > we need to fix the default. Since you're already adding it to the default configuration you can remove this now. (I'll release a new version of the configuration once that lands.) Wladimir Palant 2017/04/27 18:04:50 Done, removing it was the idea of course. Show quoted text On 2017/04/27 15:19:36, kzar wrote: > On 2017/04/27 11:46:41, Wladimir Palant wrote: > > This is necessary because our default config won't allow async functions. Yes, > > we need to fix the default. > > Since you're already adding it to the default configuration you can remove this > now. (I'll release a new version of the configuration once that lands.) Done, removing it was the idea of course.
6 }

7 }	4 }

LEFT	RIGHT