README.md - Issue 29423569: Issue 4796 - Use a modern JS engine in the browser tests and convert all files to ECMAScript 6

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: README.md

Issue 29423569: Issue 4796 - Use a modern JS engine in the browser tests and convert all files to ECMAScript 6 (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Addressed some nits Created May 3, 2017, 12:18 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: README.md

===================================================================

--- a/README.md

+++ b/README.md

@@ -7,35 +7,33 @@ serve as a dependency for `adblockplus`,

`libadblockplus`.

Running the unit tests

----------------------

### Requirements

In order to run the unit test suite you need

-[Node.js 6 or higher](https://nodejs.org/). Once Node.js is installed please run

+[Node.js 7 or higher](https://nodejs.org/). Once Node.js is installed please run

`npm install` in the repository directory in order to install the required

dependencies.

### Running all tests

`npm test` will run all tests in the `test` directory of the repository.

### Running specific tests

You can specify specific test files or directories on the command line, e.g.:

`npm test test/synchronizer.js test/browser/elemHideEmulation.html`.

### Running the browser tests in a real browser

The tests under `test/browser` require a browser environment. `npm test` will

run these in a headless browser, with each module being loaded in a new frame.

-*Note*: Currently this environment is limited to ECMAScript 5, this limitation

-should hopefully be resolved soon.

Linting

-------

You can lint the code using [ESLint](http://eslint.org).

eslint *.js chrome lib test

« no previous file with comments | « .hgignore ('k') | chrome/content/.eslintrc.json » ('j') | no next file with comments »