libadblockplus-android/jni/JniCallbacks.h - Issue 29424615: Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/jni/JniCallbacks.h

Issue 29424615: Issue 4231 - Fix unstable FilterEngineTest.testSetRemoveFilterChangeCallback (Closed)

Patch Set: now using smart_ptr, changed impl for reading file as string, minor changes Created May 22, 2017, 1:03 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: libadblockplus-android/jni/JniCallbacks.h

diff --git a/libadblockplus-android/jni/JniCallbacks.h b/libadblockplus-android/jni/JniCallbacks.h

index 27269b7cb59419fcc46188a56605d0d60bdc2924..533a0c55c9a836cbbc4f4ffa825012c6bf94c4c8 100644

--- a/libadblockplus-android/jni/JniCallbacks.h

+++ b/libadblockplus-android/jni/JniCallbacks.h

@@ -84,6 +84,18 @@ public:

void operator()(AdblockPlus::LogSystem::LogLevel logLevel, const std::string& message, const std::string& source);

};

+class JniFileSystemCallback : public JniCallbackBase, public AdblockPlus::FileSystem

+public:

+ JniFileSystemCallback(JNIEnv* env, jobject callbackObject);

+ std::shared_ptr<std::istream> Read(const std::string& path) const;

+ void Write(const std::string& path, std::shared_ptr<std::istream> data);

+ void Move(const std::string& fromPath, const std::string& toPath);

+ void Remove(const std::string& path);

+ AdblockPlus::FileSystem::StatResult Stat(const std::string& path) const;

+ std::string Resolve(const std::string& path) const;

+};

class JniShowNotificationCallback : public JniCallbackBase

{

public: